-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic][CI] Migrate linter to Ruff #47991
Labels
Comments
@MortalHappiness I'd like to help with this! |
8 tasks
This was referenced Oct 17, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 14, 2025
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
edoakes
pushed a commit
that referenced
this issue
Jan 18, 2025
## Why are these changes needed? Replace mutable default value with None to prevent shared state across ContextVar.get() calls ref : https://docs.astral.sh/ruff/rules/mutable-contextvar-default/ ## Related issue number #47991 --------- Signed-off-by: LeoLiao123 <[email protected]>
8 tasks
8 tasks
This was referenced Jan 22, 2025
8 tasks
kenchung285
added a commit
to kenchung285/ray
that referenced
this issue
Jan 24, 2025
anson627
pushed a commit
to anson627/ray
that referenced
this issue
Jan 31, 2025
…t#49854) ## Why are these changes needed? Replace mutable default value with None to prevent shared state across ContextVar.get() calls ref : https://docs.astral.sh/ruff/rules/mutable-contextvar-default/ ## Related issue number ray-project#47991 --------- Signed-off-by: LeoLiao123 <[email protected]> Signed-off-by: Anson Qian <[email protected]>
srinathk10
pushed a commit
that referenced
this issue
Feb 2, 2025
## Why are these changes needed? Replace mutable default value with None to prevent shared state across ContextVar.get() calls ref : https://docs.astral.sh/ruff/rules/mutable-contextvar-default/ ## Related issue number #47991 --------- Signed-off-by: LeoLiao123 <[email protected]>
This was referenced Feb 3, 2025
8 tasks
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened + What you expected to happen
While running the pre-commit hook of flake8, error occurs if Python version is 3.12. It's because the version of flake8 is too old.
We decided to fix this issue by migrating to
ruff
linter.Versions / Dependencies
Python 3.12
Reproduction script
If python version is 3.9 -> no error
If python version is 3.12 -> has error
Upgrade the following packages to the newest version solves this issue:
Issue Severity
Low: It annoys or frustrates me.
Subtasks tracking
flake8
andisort
withruff
#48508black
withruff format
#49436ruff
does not support Cython yet)is not
#49813getattr
with a constant attribute value. It is not any safer than normal property access. #49814setattr
with a constant attribute value. It is not any safer than normal property access. #49815{name}
imported but unused; consider usingimportlib.util.find_spec
to test for availability #49816The text was updated successfully, but these errors were encountered: