Skip to content

Commit 396493b

Browse files
authored
fix: temporary fix for double cyclic (#725)
1 parent 5f2c317 commit 396493b

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

core/job/service/job_service.go

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -357,15 +357,10 @@ func (j JobService) Validate(ctx context.Context, jobTenant tenant.Tenant, jobSp
357357
}
358358

359359
// check cyclic deps for every job
360-
isAlreadyCyclic := map[string]bool{}
361360
for _, jobEntity := range jobsWithUnresolvedUpstreams {
362-
if jobNamesWithCyclic, err := j.validateCyclic(jobEntity.Job().Spec().Name(), jobMap, identifierToJobsMap); err != nil {
363-
if _, ok := isAlreadyCyclic[jobEntity.Job().Spec().Name().String()]; !ok {
364-
me.Append(err)
365-
}
366-
for _, jobName := range jobNamesWithCyclic {
367-
isAlreadyCyclic[jobName] = true
368-
}
361+
if _, err := j.validateCyclic(jobEntity.Job().Spec().Name(), jobMap, identifierToJobsMap); err != nil {
362+
me.Append(err)
363+
break
369364
}
370365
}
371366

0 commit comments

Comments
 (0)