Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type hints in the codebase #304

Open
seranpion opened this issue Dec 6, 2021 · 2 comments
Open

Use type hints in the codebase #304

seranpion opened this issue Dec 6, 2021 · 2 comments

Comments

@seranpion
Copy link
Contributor

As I was reading the code, I noticed that it would be much easier to understand with type hints.
At least on function signatures.

Also, enforcing a max line width on the project would help readability.

@rbignon
Copy link
Owner

rbignon commented Dec 6, 2021

@seranpion
Copy link
Contributor Author

That answer is not saying much.
It's a reaction about the specific limit of 80 columns.
The last sentence summarizes my opinion as well:

And yes, we do line breaks at some point. But there really isn't any reason to make that point be 80 columns any more.

While my screen is QHD and can fit a lot of text, side panels take some space too.
I find code readability to start decreasing with lines above 120 columns (there are a couple of them here).


But anyway, back to the main point of the discussion:

What are your thoughts on type hints specifically?
If one was to introduce them in the code, would the PR be rejected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants