Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we getting too many CLI arguments? #84

Closed
gitolicious opened this issue Jun 20, 2021 · 4 comments · May be fixed by #105
Closed

Are we getting too many CLI arguments? #84

gitolicious opened this issue Jun 20, 2021 · 4 comments · May be fixed by #105

Comments

@gitolicious
Copy link
Collaborator

The current master branch scipt already has 14 CLI arguments. With the currently open PRs (#81, #83) it will be at least five more and I have plenty more in my mind. Looks like this is slowly getting out of hand. Should we switch to a config file? Any other ideas? Or just keep them coming?

@rbignon
Copy link
Owner

rbignon commented Jun 21, 2021

Hello Gitolicious,

You are right there are many arguments. However, mostly when you use doctoshotgun for someone, this is… a one shot. So command line arguments are appropriate. We can keep CLI arguments, and add another one to parse a config file :)

@rbignon
Copy link
Owner

rbignon commented Jun 21, 2021

There are currently too many opened PRs, the problem is that it complexifies the code, and some of them are incompatibles ou redundant… I have to take time to uniformise them.

@gitolicious
Copy link
Collaborator Author

In an ideal world, the script is a "one shot" (what a pun...) but in Germany currently it is really hard to find a doctor who offers appointments so you have to experiment a lot with the settings.

For PR reviews: they should be much easier and quicker when test coverage is higher as proposed in #73.

@gitolicious
Copy link
Collaborator Author

I had a quick play with a config file implementation but ultimately found it too much effort and got used to the CLI argument combination. Will close this for now until others jump in and are asking for the feature as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants