From 2f52e4c1469bceabc591968ecc42a85ebe116283 Mon Sep 17 00:00:00 2001 From: Paulo Custodio Date: Wed, 8 Jun 2016 00:04:56 +0100 Subject: [PATCH 1/2] Skip tests that hang on MSWin32 01_sysrw.t hangs on MSWin32 when tested with live handles - these tests skipped. wheel_tail.pm test hangs on MSWin32 - this test skipped. Change tested on Perl v5.22.1 built for MSWin32-x86-multi-thread-64int --- lib/POE/Loop/Select.pm | 7 ++++++- t/10_units/04_drivers/01_sysrw.t | 7 +++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/POE/Loop/Select.pm b/lib/POE/Loop/Select.pm index a8e358074..cc0fb39c6 100644 --- a/lib/POE/Loop/Select.pm +++ b/lib/POE/Loop/Select.pm @@ -13,7 +13,12 @@ $VERSION = '1.367'; # NOTE - Should be #.### (three decimal places) =for poe_tests -sub skip_tests { return } +sub skip_tests { + my($test_name) = @_; + return "$test_name tests hang on $^O" if ( + $test_name eq 'wheel_tail' && $^O eq "MSWin32" + ); +} =cut diff --git a/t/10_units/04_drivers/01_sysrw.t b/t/10_units/04_drivers/01_sysrw.t index d7caa909b..4690be3b1 100644 --- a/t/10_units/04_drivers/01_sysrw.t +++ b/t/10_units/04_drivers/01_sysrw.t @@ -98,6 +98,11 @@ ok( $d->get_out_messages_buffered() == 1, "one message buffered" ); # Remaining tests require some live handles. +SKIP: { +if ($^O eq "MSWin32") { + skip "remaining tests hang on $^O", 6; +} + my ($r, $w) = POE::Pipe::OneWay->new(); die "can't open a pipe: $!" unless $r; @@ -165,6 +170,8 @@ while (flush_remaining_buffer($d, $w)) { close(SAVE_STDERR) or die $!; } +} # SKIP + exit 0; # Buffer data, and flush it, until the pipe refuses to hold more data. From 85d14125669889947c0a43b256c653faac9dc089 Mon Sep 17 00:00:00 2001 From: Paulo Custodio Date: Wed, 8 Jun 2016 23:16:31 +0100 Subject: [PATCH 2/2] skip_test as showing up in POD display Remove empty line between =for and skip_tests so that the POD formatters ignore the skip_tests section. --- lib/POE/Loop/Select.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/POE/Loop/Select.pm b/lib/POE/Loop/Select.pm index cc0fb39c6..5ff0a16e1 100644 --- a/lib/POE/Loop/Select.pm +++ b/lib/POE/Loop/Select.pm @@ -12,7 +12,6 @@ use vars qw($VERSION); $VERSION = '1.367'; # NOTE - Should be #.### (three decimal places) =for poe_tests - sub skip_tests { my($test_name) = @_; return "$test_name tests hang on $^O" if (