-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: how to make the CI look green #26
Comments
If you use a normal GitHub CI/CD workflow badge for a workflow that has alls-green as the final job (and no following jobs), that badge will show the outcome of the entire workflow, which would essentially be whatever |
I don't think so. Use alls-green within the calling workflow. Though, you can still use it additionally inside the reusable ones, if you have a use-case, of course. |
Indeed, so far the only thing that works is displaying a badge on the top page. The commit status are still displayed as red cross, which is the main complaint I've received when trying to implement this. I have tried in vain any possible ugly way to mask the red cross, but they all seem to be blocked by Footnotes |
Yep, it's been like this ever since GHA got first released for GA (maybe even since its private beta!). I've seen countless requests to handle this with zero influence. One of the common requests used to be a Travis CI style FWIW another workaround I had in mind was setting a special |
@LecrisUT do you want to send a PR with the badge suggestion? Does the issue still need to be open? |
That is the ugly approach I was trying to do where I got stuck at overwriting
Yeah, I'll try to write a few words about that. Just ping me if I didn't get to it within 2 weeks. |
The action has a separate
Sure! I'll assign you, then. |
😮 I did not see that you can do |
This is orthogonal with what this action does, but it is a common consequence of using this action, namely how do we report on the top page that the current CI was successful? Some candidates:
alls-green
status? This is not ideal because the commit is still reported with a crossdocument using. This is still a lost cause as far as I've testedsteps.<step_id>.outcome
+ another step withexit 0
to overwrite the exit status. Haven't confirmed that this works, but it could be useful to overwrite the CI status whenon.push
, while when onon.pull_request
keep the normal reportall-green
to overwrite the job outcome of the workflow job that callsuses
? When I've tried to use it, the workflow diagram can get a bit mesy, even though the documentation suggests that they should be compressed. Some tips for people using this design would be goodUpvote & Fund
The text was updated successfully, but these errors were encountered: