Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set menu icon #31

Open
tal007 opened this issue Jun 22, 2022 · 1 comment
Open

Set menu icon #31

tal007 opened this issue Jun 22, 2022 · 1 comment

Comments

@tal007
Copy link

tal007 commented Jun 22, 2022

  • rctx-contextmenu version: 1.3.5
  • node version: 16.13.2
  • npm (or yarn) version: 8.1.2

Relevant code or config

<Submenu title="排序" icon={<EditOutlined />}>
  <ContextMenuItem></ContextMenuItem>
  <ContextMenuItem>升序</ContextMenuItem>
  <ContextMenuItem>降序</ContextMenuItem>
</Submenu>

What you did:
I want to add Icon to Submenu。

What happened:
Invalid

Reproduction repository:

Problem description:
I want to add Icon to Submenu。But it invalid.

Suggested solution:
In contentMenuItem

<div
  className={classnames(
    'contextmenu__item',
    {
      'contextmenu__item--disabled': disabled,
    },
    ...className.split(' ')
  )}
  onClick={handleClickEvent}
  {...attributes}
  ref={contextMenuItem}
>
  /* change next line */
  {icon && <div className="contextmenu__icon">{icon}</div>}
  {children}
</div>

In Submenu

<div
  className={classnames('submenu', ...className.split(' '))}
  onMouseOver={() => calculateSubmenuPos()}
  onMouseOut={() => hideSubmenu()}
  onFocus={() => null}
  onBlur={() => null}
  ref={submenuItem}
  {...attributes}
>
  /* change next line */
  <ContextMenuItem icon={icon}>{title}</ContextMenuItem>
  <div className="submenu__item" ref={submenuEl} style={submenuStyle}>
    {children}
  </div>
</div>

In index.scss

  &__icon {
    margin-right: 15px;
  }
  .submenu {
    $submenu: '.submenu';

It may work. Thanks!!!

@reachtokish
Copy link
Owner

Hi @tal007 , Thanks for reaching out. Let me check what the issue is. Will revert back soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants