Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade from 0.69.3 to 0.70.2 the version of hermes-engine not changed #323

Open
huangqiaobo opened this issue Oct 10, 2022 · 2 comments

Comments

@huangqiaobo
Copy link

huangqiaobo commented Oct 10, 2022

Bug

https://react-native-community.github.io/upgrade-helper/?from=0.69.3&to=0.70.2
After upgrade from 0.69.3 to 0.70.2
in Podfile.lock

- hermes-engine (0.69.3)

hermes-engine is still 0.69.3

React Native versions

from 0.69.3 to 0.70.2

Steps to reproduce

1.First, you need a project with 0.69.3
2.yarn in react native project
3.enable RCT_NEW_ARCH_ENABLED and pod install in iOS project
4.upgrade to 0.70.2 with https://react-native-community.github.io/upgrade-helper/?from=0.69.3&to=0.70.2
5.yarn in react native project
6.enable RCT_NEW_ARCH_ENABLED and pod install in iOS project (this step, you can't find the hermes-engine's upgrade log in pod install logs)

open the Podfile.lock, the hermes-engine is still 0.69.3

to resolve this, we need update hermes-engine

pod update hermes-engine --no-repo-update

my pod version: 1.11.3

@leotm
Copy link

leotm commented Jan 3, 2023

should be fixed in 0.71.0-rc.5+

@KevinHu2014
Copy link
Contributor

Hi @huangqiaobo, I hope you're doing well.
I wanted to check in and see if the issue is still ongoing.
(If not, let's consider closing the issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants