Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android diffs don't update with provided app package #382

Open
frankcalise opened this issue Apr 11, 2024 · 1 comment
Open

Android diffs don't update with provided app package #382

frankcalise opened this issue Apr 11, 2024 · 1 comment

Comments

@frankcalise
Copy link
Contributor

Bug

When viewing the Android diffs when providing an app package (overriding the com.rndiffapp placeholder), the diff still holds the value of com.rndiffapp in files such as build.gradle, MainActivity.java, MainActivity.kt etc

Steps to reproduce

Describe what you expected to happen:

  1. Enter in a value for What's your app package?, such as com.myapp

  2. Set versions to 0.72.10 to 0.74.0-rc.6

  3. Press Show me how to upgrade!

  4. Observe that the only place to find your provided string is the input box.

  5. Observe that com.rndiffapp is still on screen in the following files

  • android/app/build.gradle
  • android/app/src/main/java/com/myapp/MainActivity.kt (and MainActivity.java - this should so be com/rndiffapp/MainActivity.kt I think?)
@owav
Copy link

owav commented Nov 21, 2024

Same thing here.
Any new on this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants