Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一个BUG #20

Open
xiongxiong opened this issue Jul 28, 2017 · 4 comments
Open

一个BUG #20

xiongxiong opened this issue Jul 28, 2017 · 4 comments

Comments

@xiongxiong
Copy link

SortableSudokuGrid.js

line 150:
newState.containerHeight = this.createHeight(nextProps)

如果前面两个条件都不满足的话,这里newState可能为undefined,我在首页使用该控件时出现了这个问题。是否应该改作:
if (newState) {
newState.containerHeight = this.createHeight(nextProps)
}
???

@suhabaobaid
Copy link

@xiongxiong Have you found any fix for this bug?

@xiongxiong
Copy link
Author

@suhabaobaid Change the file SortableSudokuGrid.js at line 150, to:
if (newState) { newState.containerHeight = this.createHeight(nextProps) }

@suhabaobaid
Copy link

@xiongxiong Thanks! That was my initial fix...I was hoping for one not to meddle with the node_modules

@xiongxiong
Copy link
Author

@suhabaobaid You can fork the project, and publish it with another name, then change the dependency to your project, else your changes in node_modules will be drop when you update dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants