Keep focus ring styling in a single place to fix missing focus outline in some situations

Author: adamkudrna

src/lib/components/Button/_tools.scss

@@ -105,10 +105,6 @@
         opacity: theme.$disabled-opacity;
         cursor: theme.$disabled-cursor;
     }
-
-    &:-moz-focusring {
-        outline: 0;
-    }
 }
 
 @mixin button-size($size) {

src/lib/foundation.scss

@@ -9,6 +9,7 @@
 
 @use "styles/generic/box-sizing";
 @use "normalize.css/normalize.css";
+@use "styles/generic/focus";
 @use "styles/generic/forms";
 @use "styles/generic/reset";
 @use "styles/generic/shared";

src/lib/styles/generic/_focus.scss

@@ -0,0 +1,11 @@
+@use "../tools/accessibility";
+
+// Remove focus outline as we implement custom appearance of focus state. Increase specificity where necessary to
+// override normalize.css.
+:where(button, input, select, textarea):focus {
+    outline: none;
+}
+
+:is(a, button, input, select, textarea, [type="button"], [type="submit"]) {
+    @include accessibility.focus-ring();
+}

src/lib/styles/generic/_forms.scss

@@ -1,15 +1,3 @@
-@use "../tools/accessibility";
-
-// Remove focus outline as we implement custom appearance of focus state. Increase specificity where necessary to
-// override normalize.css.
-:where(button, input, select, textarea):focus {
-    outline: none;
-}
-
-:is(a, button, input, select, textarea, [type="button"], [type="submit"]) {
-    @include accessibility.focus-ring();
-}
-
 // Reset Chrome and Firefox behaviour which sets a `min-width: min-content;` on fieldsets.
 fieldset {
     min-width: 0;

src/lib/styles/tools/_reset.scss

@@ -19,7 +19,6 @@
     &:hover,
     &:focus {
         text-decoration: none;
-        outline: none;
     }
 }