[lazerg]

Summary:

On Android, removing accessibilityValue from a view leaves its content description wrong. Pressable always passes {max, min, now, text}, so the removal reaches native as a map without text, and setAccessibilityValue only rebuilt the description when text was there, so the old value stayed. View passes null instead, and that branch called setContentDescription(null), which dropped the label and state along with the value.

setAccessibilityValue now stores the value and always rebuilds the description from the label, state and value tags. updateViewContentDescription sets the description to null when there is nothing left, so a view that only had a value text still ends up with no description.

Fixes #59536

Changelog:

[ANDROID] [FIXED] - Removing accessibilityValue no longer leaves its text in the content description or drops the accessibilityLabel

Test Plan:

Added three tests to BaseViewManagerTest: a value map without text removes the old text, a null value keeps the label, and a null value clears a description that only had the value text. The first two fail on main and pass with this change. ./gradlew :packages:react-native:ReactAndroid:testDebugUnitTest passes, and the Java and Kotlin format checks are clean. I didn't run the reproducer on a device.

[github-actions]

Visual regression

No visual differences at 8cc94ff1487a.

ios: no capture

[meta-codesync]

@javache has imported this pull request. If you are a Meta employee, you can view this in D128187908.

[react-native-bot]

This pull request was successfully merged by @lazerg in 25b05ac

^{When will my fix make it into a release? | How to file a pick request?}