Repository navigation
Conversation
Summary: Props diffing (`enablePropsUpdateReconciliationAndroid`) applies to every component whose props implement `getDiffProps`, which includes all codegen components. On view creation, props equal to their C++ default are not sent, so a native component whose default differs from the C++ default ends up with the wrong value. Third-party components have not been checked for this, which makes the existing flag unsafe to try in OSS. This adds `enableCoreComponentsPropsUpdateReconciliationAndroid`, released in the experimental stage, which enables props diffing only for the core components with hand-written props (View, Paragraph, Text, RawText, TextEffect, Image, ScrollView). All other components keep receiving raw props. TextInput is intentionally not included: on Android its component name is `AndroidTextInput` while its props report `TextInput` as the diffing target, so props diffing has never applied to it under either flag. Fixing that is left for a separate change. The decision now lives in a single non-virtual function, `isPropsDiffingEnabled`, used by both `FabricMountingManager::getProps` and `ConcreteComponentDescriptor::cloneProps`, so the two decisions cannot diverge. Behavior with the new flag off is unchanged. The Android ScrollViews (vertical, nested and horizontal) switch their native default `overflow` from `scroll` to `visible` under props diffing, because the C++ default `visible` is never sent. This switch only checked `enablePropsUpdateReconciliationAndroid`, so with only the new flag enabled ScrollViews clipped their content. The default is now resolved in one place, `ReactScrollViewHelper.getDefaultOverflow()`, which checks both flags. Changelog: [Android][Added] - Add experimental feature flag `enableCoreComponentsPropsUpdateReconciliationAndroid` to send prop updates based on props diffing for core components only Differential Revision: D127587361
Summary: `isPropsDiffingEnabled` only uses props diffing when a component's name matches the target returned by its props' `getDiffPropsImplementationTarget()`. On Android the TextInput component is named `AndroidTextInput`, but `AndroidTextInputProps` returned `TextInput`. The check always failed, so TextInput never used props diffing, even with `enablePropsUpdateReconciliationAndroid` on. It kept receiving raw props (or accumulated raw props) instead, and `AndroidTextInputProps::getDiffProps` was never called. This makes `AndroidTextInputProps` return `AndroidTextInput` and adds it to the core components covered by `enableCoreComponentsPropsUpdateReconciliationAndroid`. This changes behavior for anyone with `enablePropsUpdateReconciliationAndroid` enabled: TextInput now receives diffed props built by `AndroidTextInputProps::getDiffProps`, a code path that has not been exercised before. With both props diffing flags off, behavior is unchanged. Changelog: [Android][Fixed] - Fix props diffing never being applied to `TextInput` when props update reconciliation is enabled Differential Revision: D128563541
Summary:
With props diffing, a prop whose value equals its C++ default is not sent when the view is created, so the C++ default has to match the state of a newly created native view. Several `AndroidTextInputProps` fields did not:
- `showSoftInputOnFocus` and `allowFontScaling` defaulted to `false` in C++ but are `true` natively, so setting them to `false` from JS had no effect.
- `autoCorrect` was a plain `bool` defaulting to `false`, while the native setter has three states (on, off, unset). `autoCorrect={false}` was never sent and removing the prop could not restore the platform default. It is now `std::optional<bool>` and is sent as `null` when unset.
- `numberOfLines`, `textBreakStrategy` and `includeFontPadding` were each emitted twice, once from the paragraph attributes and once from a duplicate flat field, with the later one overwriting the earlier. The flat `includeFontPadding` defaulted to `false` while the native default is `true`, so removing `includeFontPadding={true}` sent `false`. These keys are now only emitted from the paragraph attributes.
The flat fields are not used for layout, which reads the paragraph and text attributes, so only the props sent to the native view change.
Changelog:
[Android][Fixed] - Fix `TextInput` props `showSoftInputOnFocus`, `allowFontScaling`, `autoCorrect` and `includeFontPadding` being ignored or reset incorrectly when props diffing is enabled
Differential Revision: D128594780
Summary: `HostPlatformViewProps::getDiffProps` sends a `scroll` key with the same value as `overflow` whenever clipping changes. No Android view manager has a `scroll` prop and nothing reads that key directly; every component reads `overflow`. `ViewProps.SCROLL` is the overflow value `"scroll"`, not a prop name. The key only adds a JNI string and a failed setter lookup per update, so remove it. Changelog: [Internal] Differential Revision: D128598698
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128598698. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
HostPlatformViewProps::getDiffPropssends ascrollkey with the same value asoverflowwhenever clipping changes. No Android view manager has ascrollprop and nothing reads that key directly; every component readsoverflow.ViewProps.SCROLLis the overflow value"scroll", not a prop name. The key only adds a JNI string and a failed setter lookup per update, so remove it.Changelog:
[Internal]
Differential Revision: D128598698