Skip to content

Commit 984334a

Browse files
cipolleschicipolleschi
authored
Kitchen sink changes (#2030)
Summary: X-link: react/react-native#58712 Disclaimer: Brought by vibing with Gemini. ## Changelog: [Internal] - Typos Test Plan: N/A - they are only typos fixes Reviewed By: javache Pulled By: cipolleschi Differential Revision: D122122336 Pull Request resolved: #2031
1 parent d81d9c0 commit 984334a

27 files changed

Lines changed: 88 additions & 87 deletions

‎.github/ISSUE_TEMPLATE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
# Issues and Steps to Reproduce
66

7-
_**Replaces this with steps to repro your issue.**_
7+
_**Replace this with steps to repro your issue.**_
88

99
# Expected Behavior
1010

‎gentest/fixtures/YGBoxSizingTest.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@
2626
</div>
2727
</div>
2828

29-
<div id="box_sizing_content_box_comtaining_block"
29+
<div id="box_sizing_content_box_containing_block"
3030
style="width: 100px; height: 100px; padding: 12px; border-width: 8px; box-sizing: content-box; ">
3131
<div style="width: 75; height: 75; position: static;">
3232
<div style="width: 50px; height: 25%; position: absolute;">
3333
</div>
3434
</div>
3535
</div>
3636

37-
<div id="box_sizing_border_box_comtaining_block"
37+
<div id="box_sizing_border_box_containing_block"
3838
style="width: 100px; height: 100px; padding: 12px; border-width: 8px; box-sizing: border-box; ">
3939
<div style="width: 75; height: 75; position: static;">
4040
<div style="width: 50px; height: 25%; position: absolute;">

‎gentest/fixtures/YGFlexDirectionTest.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@
273273
</div>
274274
</div>
275275

276-
<div id="flex_direction_row_reverse_inner_marign_start" style="height: 100px; width: 100px;">
276+
<div id="flex_direction_row_reverse_inner_margin_start" style="height: 100px; width: 100px;">
277277
<div style="height: 100px; width: 100px; flex-direction: row-reverse; ">
278278
<div style="width: 10px; height: 10px; position: absolute; margin-inline-start: 10px"></div>
279279
<div style="width: 10px;"></div>

‎gentest/fixtures/YGRoundingTest.html‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424
<div style="height: 10px; flex-grow:1;"></div>
2525
</div>
2626

27-
<div id="rounding_total_fractial" style="height: 113.4px; width: 87.4px;">
27+
<div id="rounding_total_fractional" style="height: 113.4px; width: 87.4px;">
2828
<div style="height: 20.3px; flex-grow:0.7; flex-basis:50.3px;"></div>
2929
<div style="height: 10px; flex-grow:1.6;"></div>
3030
<div style="height: 10.7px; flex-grow:1.1;"></div>
3131
</div>
3232

33-
<div id="rounding_total_fractial_nested" style="height: 113.4px; width: 87.4px;">
33+
<div id="rounding_total_fractional_nested" style="height: 113.4px; width: 87.4px;">
3434
<div style="height: 20.3px; flex-grow:0.7; flex-basis:50.3px;">
3535
<div style="bottom: 13.3px; height: 9.9px; flex-grow:1; flex-basis:0.3px;"></div>
3636
<div style="top: 13.3px; height: 1.1px; flex-grow:4; flex-basis:0.3px;"></div>
@@ -39,25 +39,25 @@
3939
<div style="height: 10.7px; flex-grow:1.1;"></div>
4040
</div>
4141

42-
<div id="rounding_fractial_input_1" style="height: 113.4px; width: 100px;">
42+
<div id="rounding_fractional_input_1" style="height: 113.4px; width: 100px;">
4343
<div style="height: 20px; flex-grow:1; flex-basis:50px;"></div>
4444
<div style="height: 10px; flex-grow:1;"></div>
4545
<div style="height: 10px; flex-grow:1;"></div>
4646
</div>
4747

48-
<div id="rounding_fractial_input_2" style="height: 113.6px; width: 100px;">
48+
<div id="rounding_fractional_input_2" style="height: 113.6px; width: 100px;">
4949
<div style="height: 20px; flex-grow:1; flex-basis:50px;"></div>
5050
<div style="height: 10px; flex-grow:1;"></div>
5151
<div style="height: 10px; flex-grow:1;"></div>
5252
</div>
5353

54-
<div id="rounding_fractial_input_3" style="top: 0.3px; height: 113.4px; width: 100px;">
54+
<div id="rounding_fractional_input_3" style="top: 0.3px; height: 113.4px; width: 100px;">
5555
<div style="height: 20px; flex-grow:1; flex-basis:50px;"></div>
5656
<div style="height: 10px; flex-grow:1;"></div>
5757
<div style="height: 10px; flex-grow:1;"></div>
5858
</div>
5959

60-
<div id="rounding_fractial_input_4" style="top: 0.7px; height: 113.4px; width: 100px;">
60+
<div id="rounding_fractional_input_4" style="top: 0.7px; height: 113.4px; width: 100px;">
6161
<div style="height: 20px; flex-grow:1; flex-basis:50px;"></div>
6262
<div style="height: 10px; flex-grow:1;"></div>
6363
<div style="height: 10px; flex-grow:1;"></div>

‎java/tests/com/facebook/yoga/utils/TestUtils.kt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ class TestUtils {
4343
if (heightMode == YogaMeasureMode.EXACTLY) {
4444
height
4545
} else if (heightMode == YogaMeasureMode.AT_MOST) {
46-
Math.min(caclulateHeight(text, effectiveWidth), height)
46+
Math.min(calculateHeight(text, effectiveWidth), height)
4747
} else {
48-
caclulateHeight(text, effectiveWidth)
48+
calculateHeight(text, effectiveWidth)
4949
}
5050

5151
return YogaMeasureOutput.make(measuredWidth, measuredHeight)
@@ -69,7 +69,7 @@ class TestUtils {
6969
}
7070

7171
@JvmStatic
72-
fun caclulateHeight(text: String, measuredWidth: Float): Float {
72+
fun calculateHeight(text: String, measuredWidth: Float): Float {
7373
if (text.length * widthPerChar <= measuredWidth) {
7474
return heightPerChar
7575
}

‎java/tests/generated/com/facebook/yoga/YGBoxSizingTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<64f7c00c771a778087193683ffc31a13>>
7+
* @generated SignedSource<<bcb2416e24396085c1fd7e507fbb5a66>>
88
* generated by gentest/src/GentestDriver.ts from gentest/fixtures/YGBoxSizingTest.html
99
*/
1010

@@ -253,7 +253,7 @@ public void test_box_sizing_border_box_absolute() {
253253
}
254254

255255
@Test
256-
public void test_box_sizing_content_box_comtaining_block() {
256+
public void test_box_sizing_content_box_containing_block() {
257257
YogaConfig config = YogaConfigFactory.create();
258258

259259
final YogaNode root = createNode(config);
@@ -311,7 +311,7 @@ public void test_box_sizing_content_box_comtaining_block() {
311311
}
312312

313313
@Test
314-
public void test_box_sizing_border_box_comtaining_block() {
314+
public void test_box_sizing_border_box_containing_block() {
315315
YogaConfig config = YogaConfigFactory.create();
316316

317317
final YogaNode root = createNode(config);

‎java/tests/generated/com/facebook/yoga/YGFlexDirectionTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<99d3d24aad2ad28e77c81f979f9930fe>>
7+
* @generated SignedSource<<550e14075332f175edc309854b44ebf4>>
88
* generated by gentest/src/GentestDriver.ts from gentest/fixtures/YGFlexDirectionTest.html
99
*/
1010

@@ -2866,7 +2866,7 @@ public void test_flex_direction_col_reverse_inner_margin_bottom() {
28662866
}
28672867

28682868
@Test
2869-
public void test_flex_direction_row_reverse_inner_marign_start() {
2869+
public void test_flex_direction_row_reverse_inner_margin_start() {
28702870
YogaConfig config = YogaConfigFactory.create();
28712871

28722872
final YogaNode root = createNode(config);

‎java/tests/generated/com/facebook/yoga/YGRoundingTest.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<e1d10895d8799d81a66f0c2ef95b661d>>
7+
* @generated SignedSource<<09c0fd4b2affd40533e3e0469b77eb30>>
88
* generated by gentest/src/GentestDriver.ts from gentest/fixtures/YGRoundingTest.html
99
*/
1010

@@ -332,7 +332,7 @@ public void test_rounding_flex_basis_overrides_main_size() {
332332
}
333333

334334
@Test
335-
public void test_rounding_total_fractial() {
335+
public void test_rounding_total_fractional() {
336336
YogaConfig config = YogaConfigFactory.create();
337337

338338
final YogaNode root = createNode(config);
@@ -403,7 +403,7 @@ public void test_rounding_total_fractial() {
403403
}
404404

405405
@Test
406-
public void test_rounding_total_fractial_nested() {
406+
public void test_rounding_total_fractional_nested() {
407407
YogaConfig config = YogaConfigFactory.create();
408408

409409
final YogaNode root = createNode(config);
@@ -508,7 +508,7 @@ public void test_rounding_total_fractial_nested() {
508508
}
509509

510510
@Test
511-
public void test_rounding_fractial_input_1() {
511+
public void test_rounding_fractional_input_1() {
512512
YogaConfig config = YogaConfigFactory.create();
513513

514514
final YogaNode root = createNode(config);
@@ -579,7 +579,7 @@ public void test_rounding_fractial_input_1() {
579579
}
580580

581581
@Test
582-
public void test_rounding_fractial_input_2() {
582+
public void test_rounding_fractional_input_2() {
583583
YogaConfig config = YogaConfigFactory.create();
584584

585585
final YogaNode root = createNode(config);
@@ -650,7 +650,7 @@ public void test_rounding_fractial_input_2() {
650650
}
651651

652652
@Test
653-
public void test_rounding_fractial_input_3() {
653+
public void test_rounding_fractional_input_3() {
654654
YogaConfig config = YogaConfigFactory.create();
655655

656656
final YogaNode root = createNode(config);
@@ -722,7 +722,7 @@ public void test_rounding_fractial_input_3() {
722722
}
723723

724724
@Test
725-
public void test_rounding_fractial_input_4() {
725+
public void test_rounding_fractional_input_4() {
726726
YogaConfig config = YogaConfigFactory.create();
727727

728728
final YogaNode root = createNode(config);

‎javascript/tests/generated/YGBoxSizingTest.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<a412a7c5a9ab605a584532557337f2be>>
7+
* @generated SignedSource<<f998f0664e83f08f8791569e89d21ccb>>
88
* generated by gentest/src/GentestDriver.ts from gentest/fixtures/YGBoxSizingTest.html
99
*/
1010

@@ -229,7 +229,7 @@ test('box_sizing_border_box_absolute', () => {
229229
expect(root_child0.getComputedWidth()).toBe(40);
230230
expect(root_child0.getComputedHeight()).toBe(40);
231231
});
232-
test('box_sizing_content_box_comtaining_block', () => {
232+
test('box_sizing_content_box_containing_block', () => {
233233
const config = Yoga.Config.create();
234234

235235
const root = Yoga.Node.create(config);
@@ -283,7 +283,7 @@ test('box_sizing_content_box_comtaining_block', () => {
283283
expect(root_child0_child0.getComputedWidth()).toBe(50);
284284
expect(root_child0_child0.getComputedHeight()).toBe(31);
285285
});
286-
test('box_sizing_border_box_comtaining_block', () => {
286+
test('box_sizing_border_box_containing_block', () => {
287287
const config = Yoga.Config.create();
288288

289289
const root = Yoga.Node.create(config);

‎javascript/tests/generated/YGFlexDirectionTest.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<dcb6dba05da62f9f0f72579939bf8979>>
7+
* @generated SignedSource<<5dfcd1fe48bc4e6042be9a9dfc35252d>>
88
* generated by gentest/src/GentestDriver.ts from gentest/fixtures/YGFlexDirectionTest.html
99
*/
1010

@@ -2714,7 +2714,7 @@ test('flex_direction_col_reverse_inner_margin_bottom', () => {
27142714
expect(root_child0_child2.getComputedWidth()).toBe(10);
27152715
expect(root_child0_child2.getComputedHeight()).toBe(0);
27162716
});
2717-
test('flex_direction_row_reverse_inner_marign_start', () => {
2717+
test('flex_direction_row_reverse_inner_margin_start', () => {
27182718
const config = Yoga.Config.create();
27192719

27202720
const root = Yoga.Node.create(config);

0 commit comments

Comments
 (0)