Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hebrew Translation Progress #1

Closed
60 of 88 tasks
tesseralis opened this issue Feb 10, 2019 · 60 comments
Closed
60 of 88 tasks

Hebrew Translation Progress #1

tesseralis opened this issue Feb 10, 2019 · 60 comments

Comments

@tesseralis
Copy link
Member

tesseralis commented Feb 10, 2019 •
edited by galnir
Loading

Maintainer List

For New Translators

To translate a page:

  1. Check that no one else has claimed your page in the checklist and comments below.
  2. Comment below with the name of the page you would like to translate. Please take only one page at a time.
  3. Clone this repo, translate your page, and submit a pull request!

Before contributing, read the glossary and style guide (once they exist) to understand how to translate various technical and React-specific terms.

Please be prompt with your translations! If you find find that you can't commit any more, let the maintainers know so they can assign the page to someone else.

For Maintainers

When someone volunteers, edit this issue with the username of the volunteer, and with the PR. Ex:

When PRs are merged, make sure to mark that page as completed!

Core Pages

To do before releasing as an "official" translation. Please translate these pages first.

Basics

API Reference

Navigation

These are the navigation links that appears in the sidebar. Possibly wait until
the corresponding sections are translated to do these.

Next Steps

These are the next most important translations, ordered by importance:

Installation

Hooks

Everyone is hooked on hooks! People are really excited for these and it would be great for them to be translated.

Warnings

These are the pages that you get when you click the links in the console (e.g. https://reactjs.org/warnings/dont-call-proptypes.html). People tend to search these, so please don't translate the error message itself.

Advanced Guides

FAQ

Contributing

Priority: Low

  • How to Contribute
  • Codebase Overview
  • Implementation Notes
  • Design Principles

Components

Components in src/components that have some text in them.

Additional Translations

These are not the primary translation targets.

  • Blog
  • Community
@tesseralis tesseralis mentioned this issue Feb 10, 2019
Merged
@gmadar
Copy link
Contributor

gmadar commented Feb 10, 2019

  • Home Page

@bentlusty
Copy link
Contributor

@gmadar Added you to Home page. thank you!

@galtalmor
Copy link
Collaborator

  • Tutorial

@galnir
Copy link
Collaborator

galnir commented Feb 14, 2019 •
edited
Loading

@galtalmor Added you to the tutorial

@galtalmor
Copy link
Collaborator

@gmadar Added you to the tutorial

Wrong mention, bug tagging is okay :)

@galnir
Copy link
Collaborator

galnir commented Feb 14, 2019

@galtalmor oops sorry

@bromy
Copy link
Contributor

bromy commented Feb 14, 2019

  • Hello World

@galnir
Copy link
Collaborator

galnir commented Feb 14, 2019

@bromy It's yours 👍

@galnir
Copy link
Collaborator

galnir commented Feb 15, 2019 •
edited
Loading

Does anyone have a solution for fixing punctuation when translating into hebrew? There is an example in gmadar's pull request:
screenshot_3

It also happens on my end when I translate sentences

@galtalmor
Copy link
Collaborator

galtalmor commented Feb 18, 2019 •
edited
Loading

Does anyone have a solution for fixing punctuation when translating into Hebrew?

I suppose it will just require some CSS tweaking with direction: rtl, but I'm not sure how would that work with the way they build and publish this website. I think it is best to try and contact someone from the team in charge to figure out if it is okay to make changes in the website's CSS since this problem will exist everywhere with this translation.

More specifically, adding the following code in the file algolia.css solved the basic issues for me, but requires more tweaking to make everything look better:

p, h1, h2, h3, ul, details {
  direction: rtl;
}

code {
  direction: ltr;
  display: inline-block;
}

@tesseralis
Copy link
Member Author

@galtalmor It's definitely okay to make changes to the CSS -- Arabic and Persian dealt with the same thing and actually have PRs to do it: reactjs/ar.react.dev#8

You might want to post there to see if they can help you set it up for Hebrew!

@galnir
Copy link
Collaborator

galnir commented Feb 18, 2019

@galtalmor A member of the Arabic translation team already helped us with that :) #6

@galtalmor
Copy link
Collaborator

@galtalmor A member of the Arabic translation team already helped us with that :) #6

👍

@dormd
Copy link
Contributor

dormd commented Feb 23, 2019

Awesome idea 😍
Rendering Elements

@galnir
Copy link
Collaborator

galnir commented Feb 23, 2019

@dormd It's yours :)

@galtalmor
Copy link
Collaborator

  • Getting Started

@itayyehezkel
Copy link
Collaborator

Introducing Hooks

@galtalmor
Copy link
Collaborator

Hey @bentlusty & @galnir I think you guys should update this main thread, it's starting to be hard to follow on what is already completed, what's not and who's working on stuff. I wouldn't mind helping with that if you guys are too busy. Thanks!

@galtalmor
Copy link
Collaborator

galtalmor commented Feb 25, 2019 •
edited
Loading

Here's the list of completed tasks with related PRs:

@galtalmor
Copy link
Collaborator

  • Components and Props

@galnir
Copy link
Collaborator

galnir commented Feb 25, 2019

@tesseralis Can you please add @galtalmor as a maintainer? It would really help us keep up with the work

@tesseralis
Copy link
Member Author

@galnir sure! In the future you can open a PR if you need to add more maintainers.

@tesseralis
Copy link
Member Author

@galtalmor once you accept the invite to join the reactjs org you should be able to update this issue :)

@galtalmor
Copy link
Collaborator

@galtalmor once you accept the invite to join the reactjs org you should be able to update this issue :)

@tesseralis Yep, it works. Thanks!

@bromy
Copy link
Contributor

bromy commented Feb 25, 2019

As you are all working on these, I was wondering about what setup or process you are using in your text editor. Working with the mixed left-to-right/right-to-left text files made the formatting more of a challenge than it should have been 😄. Text kept jumping around, highlighting/copying/pasting felt unpredictable, and the markdown syntax was easily thrown off. Are there any editor or OS settings that made it more intuitive to work with the bidirectional nature of the text?

@galnir
Copy link
Collaborator

galnir commented Feb 25, 2019

@bromy My main text editor is vscode, but it doesn't support right to left(in my experience). so for translation I use notepad++

@galtalmor
Copy link
Collaborator

@bromy I use WebStorm, it doesn't really support RTL (doesn't let you control it or stick the code to the right), but when the first word is in hebrew it kinda justifies the content in RTL, so it is good enough for me. Also it got a markup plugin that lets you see changes on the fly, so that is also pretty helpful.
I don't think there will be any really good solution here, but I will be happy to be surprised.

@dormd
Copy link
Contributor

dormd commented Feb 26, 2019

CDN Links

@itayyehezkel
Copy link
Collaborator

MarkdownPage

@rgrnwd
Copy link

rgrnwd commented May 22, 2019

Hey, I'm keen to contribute. I'll start with the Accessibility page, if that's ok with everyone? :)

@galnir
Copy link
Collaborator

galnir commented May 22, 2019

@rgrnwd That's great, thanks!

@rgrnwd
Copy link

rgrnwd commented May 31, 2019

Can I pick up Error Boundaries next? Thanks!

@galnir
Copy link
Collaborator

galnir commented Jun 1, 2019

@rgrnwd 👍

@rgrnwd
Copy link

rgrnwd commented Jun 7, 2019

Context & Forwarding Refs next 😃

@rgrnwd rgrnwd mentioned this issue Jun 8, 2019
Merged
@galnir
Copy link
Collaborator

galnir commented Jun 10, 2019

@tesseralis hey, should we also translate pages like 404/versions/acknowlegements?

@galnir galnir mentioned this issue Jun 16, 2019
Closed
@tsehori
Copy link

tsehori commented Jun 21, 2019

Hey, can I pick up Uncontrolled Components and React Without JSX?
Thanks!

@galnir
Copy link
Collaborator

galnir commented Jun 21, 2019

@tsehori Ofc 👍

@tesseralis
Copy link
Member Author

@itayyehezkel @galtalmor I'm going to open up your pages React and TestRenderer for now since it's been a while, so if anyone wants to take those pages to finish up the core translation, now's your chance!

@galnir I'm not sure which page that is? Do you have a link to the english react website for it?

@galnir
Copy link
Collaborator

galnir commented Jun 25, 2019

@tesseralis
404 (page not found): https://reactjs.org/dhxnxdj

@tesseralis
Copy link
Member Author

Yeah! That should be translated.

@rgrnwd
Copy link

rgrnwd commented Jul 13, 2019

Can I translate Code-Splitting and higher order components?

@rgrnwd rgrnwd mentioned this issue Jul 13, 2019
Merged
@galnir galnir mentioned this issue Aug 5, 2019
Closed
@tesseralis
Copy link
Member Author

@galtalmor how is the API->React translation going? It's the last one we need to mark this as completed so we're eager to get that done!

@orrsteinberg
Copy link
Contributor

Hey, I'd be happy to contribute. Is there anything that has high priority/that would be particularly helpful?
If not, I'll start with Passing Functions to Components in the FAQ section if that's alright.

@galtalmor
Copy link
Collaborator

@orrsteinberg anything that isn't complete yet

@orrsteinberg
Copy link
Contributor

Got it 👍 I'll get right on it then.

@orrsteinberg orrsteinberg mentioned this issue Feb 3, 2021
Merged
gaearon pushed a commit that referenced this issue Aug 5, 2021
@trueadm
Merge pull request #1 from alexkrolick/create-ref-patch
c07a6b0 
createRef tweaks and suggestions
gaearon pushed a commit that referenced this issue Aug 5, 2021
@bvaughn
Merge pull request #1 from trueadm/create-ref
fecb153 
Merge createRef docs into 16.3 release blog
@owolfy
Copy link
Contributor

owolfy commented Aug 7, 2022

I saw some typos and inconsistent translations.
What is the convention for revisions PR?

@galnir
Copy link
Collaborator

galnir commented Aug 7, 2022

I saw some typos and inconsistent translations.
What is the convention for revisions PR?

Open a PR with the fixes, nothing special

@galnir
Copy link
Collaborator

galnir commented Sep 28, 2022

#280

@galnir galnir closed this as completed Sep 28, 2022
rickhanlonii pushed a commit that referenced this issue Apr 24, 2023
@renancouto
Fix legacy link (#1)
7863b5b
@gaearon gaearon unpinned this issue Apr 25, 2023
@gaearon
Copy link
Member

gaearon commented Apr 25, 2023

Thanks to everyone who worked on the old translation!
I've updated the TODO list for the new one in #280.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests