Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Next 15 Canary and enable React Compiler #6996

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mattcarrollcode
Copy link
Contributor

@mattcarrollcode mattcarrollcode commented Jun 26, 2024

This change upgrades React.dev from Next 13.4.1 to Next 15 Canary and and enables the React Complier

Preview, 19 Preview

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 0:58am
react-dev ✅ Ready (Inspect) Visit Preview Jun 28, 2024 0:58am

Copy link

github-actions bot commented Jun 26, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 107.85 KB (🟡 +3.66 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 123.38 KB (🔴 +19.11 KB) 231.24 KB
/500 123.4 KB (🔴 +19.13 KB) 231.25 KB
/[[...markdownPath]] 125.31 KB (🔴 +19.19 KB) 233.17 KB
/_error 189 B (🟡 +8 B) 108.04 KB
/errors 123.67 KB (🔴 +19.19 KB) 231.52 KB
/errors/[errorCode] 123.65 KB (🔴 +19.18 KB) 231.5 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Co-authored-by: Sebastian Markbåge <[email protected]>
@mattcarrollcode mattcarrollcode changed the title [WIP] Upgrade to Next 15 RC and enable React Compiler Upgrade to Next 15 Canary in preparation for React Compiler Jun 28, 2024
@mattcarrollcode mattcarrollcode changed the title Upgrade to Next 15 Canary in preparation for React Compiler Upgrade to Next 15 Canary and enable React Compiler Jun 28, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon Do you know if there a better way to do this now? In your PR where you introduced this patch you mentioned that you'd hope there would be a way to customize this back in Next v12.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this just seemed like maybe a bug? try getting the build to fail in the same way as the PR mentioned in the original PR and see if it passes CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants