Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated resync for deleted & renamed books #17

Open
xxchan opened this issue Jan 7, 2023 · 2 comments
Open

duplicated resync for deleted & renamed books #17

xxchan opened this issue Jan 7, 2023 · 2 comments
Assignees

Comments

@xxchan
Copy link

xxchan commented Jan 7, 2023

Steps to reproduce:

  1. Delete a synced book old name in Logseq
  2. Rename the book to new name in readwise
  3. Initiate Sync in Logseq (with "Resync deleted pages" enabled), now we have the page new name
  4. Initiate again (actually in each sync afterwards), there will be another notification for new name, but nothing changed.

The reason is simple:

Look at the log:

Page 'old name' deleted, going to resync.

Look at settings.json:

"booksIDsMap": {
    "old name": id,
    "new name": id,
}
@xxchan
Copy link
Author

xxchan commented Jan 7, 2023

Not sure whether #7 is caused by this issue.

@brunojm brunojm self-assigned this Jan 7, 2023
@brunojm
Copy link
Contributor

brunojm commented Jan 7, 2023

Thanks @xxchan for reporting this, I'm going to change the way we save the ids info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants