[DRAFT/WIP] feature: prefer frontmatter book IDs if present #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-dot-earth
force-pushed
the
prefer-frontmatter-bookids
branch
3 times, most recently
from
12b35bc
to
39ba5dc
Compare
tyler-dot-earth
force-pushed
the
prefer-frontmatter-bookids
branch
from
39ba5dc
to
d4b821d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 WIP 🚧
this is a continuation of the work started in #62 - don't worry, I will rebase this branch once that PR is merged so the history is clean ✨
context
Building on top of the work in #62, this PR is focused on preferring book IDs in frontmatter over those in
data.json'ssettings.booksIDsMapif the frontmatter book ID is present.I want to emphasize: utilization of the frontmatter book ID remains completely optional with these changes - all users will be able to continue using the plugin as they have been (without frontmatter).