Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify template by removing custom handler #14

Open
thheller opened this issue Nov 8, 2021 · 1 comment
Open

Simplify template by removing custom handler #14

thheller opened this issue Nov 8, 2021 · 1 comment

Comments

@thheller
Copy link

thheller commented Nov 8, 2021

The template (shadow-cljs variant) generates a src/user.clj with a custom handler. The only purpose of this handler seems to be to serve classpath resources from the public prefix. This can be done purely via shadow-cljs.edn :dev-http config and does not need a custom handler.

Just turn

{...
 :dev-http     {3000 {:root    "public"
                      :handler user/app}}}

into

{...
 :dev-http     {3000 ["public" "classpath:public"]}}

as mentioned in the docs.

@yogthos
Copy link
Member

yogthos commented Nov 8, 2021

Yeah that sounds reasonable to me, any chance you could do a pr with the update? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants