Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bundling Lua and Python with Noorg #6

Open
realjockel opened this issue Dec 14, 2024 · 2 comments
Open

Improve bundling Lua and Python with Noorg #6

realjockel opened this issue Dec 14, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@realjockel
Copy link
Owner

Current approach requires a lot of manual dependency installation and configuration. Find a better way to bundle those core dependencies with the binary.

@realjockel realjockel added enhancement New feature or request help wanted Extra attention is needed labels Dec 14, 2024
@hhoeflin
Copy link

hhoeflin commented Dec 15, 2024

My 2 cents here:
a) For Lua, as it is lightweight and intended as an embedded scripting language, I think it should be completely vendored.
b) For python - I haven´t looked at how deeply you want the integration, or if you need integration at all? Think of linters for programming languages (like black or ruff in python). They work perfectly as binaries and can be called as external binaries. Communication is in JSON already anyway, so could be done some way through stdin and stdout. Then anyone could write add-one tools as standalone binaries. What about your python scripts in this case? Turn them into python packages with a standardized CLI. I guess the key question here what kind of performance you are expecting from external "observers".

@tsackit
Copy link

tsackit commented Jan 3, 2025

as mentioned @hhoeflin, for lua there would be no major complications. Can be use the standalone mode.

But for python, I found this comment in the Pyo3 repo.

I will be testing this issue this weekend. 🙋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants