Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-changelog doesn't bump version on "internals" -only changes #46

Open
kraenhansen opened this issue Feb 28, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@kraenhansen
Copy link
Member

If the changelog contains only "Internals" the action will suggest releasing a release with the same version as the previous version.

let newVersion = prevVersion;
let sectionMatch: SectionMatch | null;
sectionsRegex.lastIndex = 0;
while ((sectionMatch = matchSections(sections))) {
if (!hasActualChanges(sectionMatch.groups.sectionContent)) {
continue;
}
const inferredNewVersion = getNextVersion(prevVersion, sectionMatch.groups.sectionName);
if (inferredNewVersion && semver.gt(inferredNewVersion, newVersion)) {
newVersion = inferredNewVersion;
}
}

It might be possible to fix by setting newVersion = semver.inc(prevVersion, "patch") and removing the Fixed branch here:

https://github.com/realm/ci-actions/blob/6418e15ed9bbdb19b7d456a347e5623779f95cdf/update-changelog/src/helpers.ts#L124-L125C20

@kraenhansen kraenhansen added the bug Something isn't working label Feb 28, 2024
@kraenhansen kraenhansen changed the title update-changelog doesn't bump version on internal-only changes update-changelog doesn't bump version on "internals" -only changes Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant