Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update m_flx_active_version when an QUERY_ERROR occurs #7825

Closed
sync-by-unito bot opened this issue Jun 20, 2024 · 3 comments
Closed

Update m_flx_active_version when an QUERY_ERROR occurs #7825

sync-by-unito bot opened this issue Jun 20, 2024 · 3 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jun 20, 2024

The handle role change project updated the operation of subscriptions such that if a server-initiated bootstrap was started while a subscription was being bootstrapped, the subscription will be reset to the Pending state and the m_flx_last_seen_version will be reset to the m_flx_active_version value.

There was a comment posted on PR #7675, which contained this change, regarding updating the m_flx_last_seen_version when a sync session starts or when a subscription QUERY_ERROR occurs and possibly updating the validation in the SessionWrapper::on_flx_sync_progress() function regarding this value.

Since this change could have potential side effects with progress notifications which relies on the m_flx_active_version value, it was pulled out into a separate task to isolate and investigate these changes.

Copy link
Author

sync-by-unito bot commented Jun 20, 2024

➤ PM Bot commented:

Jira ticket: RCORE-2173

Copy link
Author

sync-by-unito bot commented Aug 1, 2024

➤ Jonathan Reams commented:

[~[email protected]], tracking the active version has all been reworked in 819bb98, so is this still a valid thing to do?

@sync-by-unito sync-by-unito bot closed this as completed Aug 1, 2024
Copy link
Author

sync-by-unito bot commented Aug 1, 2024

➤ michael-wb commented:

Correct - these variables have been removed and this request is no longer valid.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants