From 35c98b51ed52db70f03462c44a26533e64cab644 Mon Sep 17 00:00:00 2001 From: Alputer Date: Mon, 18 Nov 2024 11:48:19 +0100 Subject: [PATCH] fix(ui): show Jupyter badge only after notebook is running (#416) Closes #408 --- reana-ui/src/actions.js | 2 +- reana-ui/src/components/WorkflowActionsPopup.js | 2 +- reana-ui/src/components/WorkflowBadges.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/reana-ui/src/actions.js b/reana-ui/src/actions.js index 33e2112..0d8a6be 100644 --- a/reana-ui/src/actions.js +++ b/reana-ui/src/actions.js @@ -520,7 +520,7 @@ export function openInteractiveSession(id, options = {}) { "Success!", "The interactive session has been created. " + "However, it could take several minutes to start the Jupyter Notebook. " + - "Click on the Jupyter logo to access it. " + + "Click on the Jupyter notebook badge to access it. " + `${interactiveSessionInactivityWarning}`, ), ); diff --git a/reana-ui/src/components/WorkflowActionsPopup.js b/reana-ui/src/components/WorkflowActionsPopup.js index 25b6252..38ec6a5 100644 --- a/reana-ui/src/components/WorkflowActionsPopup.js +++ b/reana-ui/src/components/WorkflowActionsPopup.js @@ -38,7 +38,7 @@ export default function WorkflowActionsPopup({ workflow, className }) { const isDeleted = status === "deleted"; const isDeletedUsingWorkspace = isDeleted && size.raw > 0; const isRunning = status === "running"; - const isSessionOpen = sessionStatus === "created"; + const isSessionOpen = sessionStatus === "running"; let menuItems = []; diff --git a/reana-ui/src/components/WorkflowBadges.js b/reana-ui/src/components/WorkflowBadges.js index c1652c4..c1d1300 100644 --- a/reana-ui/src/components/WorkflowBadges.js +++ b/reana-ui/src/components/WorkflowBadges.js @@ -26,7 +26,7 @@ export default function WorkflowBadges({ workflow }) { session_status: sessionStatus, } = workflow; const hasDiskUsage = size.raw > 0; - const isSessionOpen = sessionStatus === "created"; + const isSessionOpen = sessionStatus === "running"; return (