Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: stop on fatal errors while building #449

Open
diegodelemos opened this issue Nov 11, 2020 · 0 comments
Open

docker: stop on fatal errors while building #449

diegodelemos opened this issue Nov 11, 2020 · 0 comments

Comments

@diegodelemos
Copy link
Member

Stems from reanahub/reana-job-controller#283 (review)

In reanahub/reana-job-controller#283 we spotted that an important instruction to build the docker image was failing but the image was being built "successfully". This is dangerous because we can end up with an image that doesn't fulfill the necessary requirements.

In this case we used set -e. We should runa campaign across REANA repos to find instructions like this ones that should exit on failure (w.g. wget).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant