Diagnostics and Git component update

[idr4n]

I have a diagnostics component similar to the one in the cookbook. However, I noticed that despite having update = { "DiagnosticChanged", "BufEnter" } , diagnostics only get updated once I start moving the cursor.

At the moment, I added an autocommand in my config instead to get around this:

vim.api.nvim_create_autocmd("DiagnosticChanged", {
  group = vim.api.nvim_create_augroup("Status_Diagnostics", { clear = true }),
  callback = vim.schedule_wrap(function()
    vim.cmd("redrawstatus")
    vim.cmd("redrawtabline")
  end),
})

This works fine for me but I just want to understand why simply adding update = { "DiagnosticChanged", "BufEnter" } does not work as expected. Most likely I'm missing something.

Something similar happens in the gitdiff component with update = "GitSignsUpdate". Instead, I had to add this autocommand as mentioned in the gitsigns documentation:

vim.api.nvim_create_autocmd("User", {
  group = vim.api.nvim_create_augroup("Status_GitUpdate", { clear = true }),
  pattern = "GitSignsUpdate",
  callback = vim.schedule_wrap(function()
    vim.cmd("redrawstatus")
  end),
})

Note that this didn't work for me either:

{
...
  update = { 
    "User",
    pattern = "GitSignsUpdate",
    callback = vim.schedule_wrap(function()
      vim.cmd("redrawstatus")
    end),
  }
}

Thanks in advance!

[gegoune]

Are you on nightly? I think it might be nvim issue actually as both components updated immediately in the past but I have seen this behaviour for a while now as well.

[idr4n]

Yes, I am on nightly, actually.

[gegoune]

Related #139

[marwing]

I was annoyed enough to bisect this today. The behavior was introduced in neovim/neovim@fe11079.

Just noting this here in case anyone wants to open an issue before I get to it.

minimal init.lua:

local plugins = {
  gitsigns = 'lewis6991/gitsigns.nvim',
  heirline = 'rebelot/heirline.nvim',
}

local plugin_path = '/tmp/nvim-bisect/plugins/'
(vim.uv or vim.loop).fs_mkdir(plugin_path, 0755)

for name, path in pairs(plugins) do
  local fullpath = plugin_path .. name
  if not (vim.uv or vim.loop).fs_stat(fullpath) then
    -- stylua: ignore
    vim.fn.system({ 'git', 'clone', '--depth=1', '--filter=tree:0', 'https://github.com/' .. path, fullpath, })
  end
  vim.opt.rtp:append(fullpath)
end

require('gitsigns').setup()

local function git_diff_component(s, icon)
  return {
    condition = function(self)
      return self.status_dict[s] ~= nil and self.status_dict[s] > 0
    end,
    provider = function(self)
      return ' ' .. icon .. self.status_dict[s]
    end,
  }
end

require('heirline').setup({
  statusline = {
    condition = require('heirline.conditions').is_git_repo,
    init = function(self)
      self.status_dict = vim.b.gitsigns_status_dict
    end,
    update = { 'User', patterh = 'GitSignsUpdate' },
    { -- branch
      provider = function(self)
        return self.status_dict.head
      end,
    },
    git_diff_component('added', '+'),
    git_diff_component('changed', '~'),
    git_diff_component('removed', '-'),
  },
})

bisect log:

git bisect start
# status: waiting for both good and bad commits
# bad: [067f51e3aadfeb797b38331776f2a6447b565456] Merge pull request #28183 from bfredl/intechnicolor
git bisect bad 067f51e3aadfeb797b38331776f2a6447b565456
# status: waiting for good commit(s), bad commit known
# bad: [0fe921663f1be9e32afa66874fda1ef15142a47e] Merge #15440 close 'shell' :terminal automatically
git bisect bad 0fe921663f1be9e32afa66874fda1ef15142a47e
# status: waiting for good commit(s), bad commit known
# bad: [32dc484ec9ec2d86a5fc7127e37f1ef115b9be76] fix(treesitter): support subfiletypes in get_lang (#23605)
git bisect bad 32dc484ec9ec2d86a5fc7127e37f1ef115b9be76
# status: waiting for good commit(s), bad commit known
# bad: [8a3220ba499c4c8cd74a3896f3c79e5f3d666eba] build(deps): set query parser to release (#22603)
git bisect bad 8a3220ba499c4c8cd74a3896f3c79e5f3d666eba
# status: waiting for good commit(s), bad commit known
# good: [477bbb5f5fd9e56511c4d564a308fe7c47c7841f] Merge pull request #22291 from zeertzjq/vim-8.2.0148
git bisect good 477bbb5f5fd9e56511c4d564a308fe7c47c7841f
# good: [8bd0a9c360e94b2702cbccbde838a2a7e4f8ccf1] Merge pull request #22429 from bfredl/hkmap
git bisect good 8bd0a9c360e94b2702cbccbde838a2a7e4f8ccf1
# good: [089f962d6a18bd91d89998e16834b822ab2adf9f] vim-patch:9.0.1378: illegal memory access when using virtual editing (#22527)
git bisect good 089f962d6a18bd91d89998e16834b822ab2adf9f
# good: [af23d173883f47fd02a9a380c719e4428370b484] test: move oldtests to test directory (#22536)
git bisect good af23d173883f47fd02a9a380c719e4428370b484
# good: [276b647fdba07bf1762d8dd371c4b655b8a418df] refactor(treesitter): delegate region calculation to treesitter (#22553)
git bisect good 276b647fdba07bf1762d8dd371c4b655b8a418df
# good: [e17581fa5342c7396385456faa37e78105994ed2] docs: add missing highlight groups for floats
git bisect good e17581fa5342c7396385456faa37e78105994ed2
# bad: [9ef7297ef142354ace8b1f3f277d0eee3cfdc6d4] feat(lsp): overwrite omnifunc/tagfunc set by ftplugin #22267
git bisect bad 9ef7297ef142354ace8b1f3f277d0eee3cfdc6d4
# bad: [fe11079721084b3638ae3d8e5266f95d52028fb7] perf(statusline): UI elements are always redrawn on K_EVENT
git bisect bad fe11079721084b3638ae3d8e5266f95d52028fb7
# good: [1fb585a9db32ddfa563328a4ffb18b6f1e1dec1e] test(statusline): UI elements are not redrawn on K_EVENT unnecessarily
git bisect good 1fb585a9db32ddfa563328a4ffb18b6f1e1dec1e
# first bad commit: [fe11079721084b3638ae3d8e5266f95d52028fb7] perf(statusline): UI elements are always redrawn on K_EVENT

[simonmandlik]

@marwing looks to me that you have a typo here:

update = { 'User', patterh = 'GitSignsUpdate' }

[metalinspired]

This solved it for me:

update = {
  'User',
  pattern = 'GitSignsUpdate',
  callback = vim.schedule_wrap(function() vim.cmd 'redrawstatus' end),
}

update = {
  'DiagnosticChanged',
  'BufEnter',
  callback = vim.schedule_wrap(function()
    vim.cmd 'redrawstatus'
    vim.cmd 'redrawtabline'
  end),
}