fix: add RSA SHA1 support

Author: adiwajshing

README.md

@@ -34,6 +34,7 @@ As all the cryptography is handled by either "webcrypto" or a "pure-js" implemen
 - RSA-PKCS1-SHA256
 - RSA-PKCS1-SHA384
 - RSA-PKCS1-SHA512
+- RSA-PKCS1-SHA1
 
 ### Cipher Suites (TLS 1.3)
 - AES-128-GCM-SHA256

src/crypto/webcrypto.ts

@@ -111,13 +111,22 @@ export const webcryptoCrypto: Crypto<WebCrypto.CryptoKey> = {
 		case 'RSA-PKCS1-SHA512':
 		case 'RSA-PKCS1-SHA256':
 		case 'RSA-PKCS1-SHA384':
+		case 'RSA-PKCS1-SHA1':
 			keyType = 'spki'
 			keyUsages = ['verify']
 			subtleArgs = {
 				name: 'RSASSA-PKCS1-v1_5',
 				hash: alg === 'RSA-PKCS1-SHA256'
 					? 'SHA-256'
-					: (alg === 'RSA-PKCS1-SHA384' ? 'SHA-384' : 'SHA-512')
+					: (
+						alg === 'RSA-PKCS1-SHA384'
+							? 'SHA-384'
+							: (
+								alg === 'RSA-PKCS1-SHA1'
+									? 'SHA-1'
+									: 'SHA-512'
+							)
+					)
 			}
 			break
 		case 'RSA-PCKS1_5':
@@ -296,11 +305,16 @@ export const webcryptoCrypto: Crypto<WebCrypto.CryptoKey> = {
 		case 'RSA-PKCS1-SHA512':
 		case 'RSA-PKCS1-SHA256':
 		case 'RSA-PKCS1-SHA384':
+		case 'RSA-PKCS1-SHA1':
 			verifyArgs = {
 				name: 'RSASSA-PKCS1-v1_5',
-				hash: alg === 'RSA-PKCS1-SHA256'
-					? 'SHA-256'
-					: (alg === 'RSA-PKCS1-SHA384' ? 'SHA-384' : 'SHA-512')
+				hash: alg === 'RSA-PKCS1-SHA384'
+					? 'SHA-384'
+					: (
+						alg === 'RSA-PKCS1-SHA1'
+							? 'SHA-1'
+							: 'SHA-512'
+					)
 			}
 			break
 		case 'ECDSA-SECP256R1-SHA256':

src/types/crypto.ts

@@ -17,6 +17,7 @@ export type SignatureAlgorithm = 'RSA-PSS-SHA256'
 	| 'RSA-PKCS1-SHA512'
 	| 'RSA-PKCS1-SHA384'
 	| 'RSA-PKCS1-SHA256'
+	| 'RSA-PKCS1-SHA1'
 
 export type HashAlgorithm = 'SHA-256' | 'SHA-384' | 'SHA-1'
 

src/utils/x509.ts

@@ -89,7 +89,7 @@ function getSigAlgorithm(
 		)
 	}
 
-	let hashName: 'SHA256' | 'SHA384' | 'SHA512'
+	let hashName: 'SHA256' | 'SHA384' | 'SHA512' | 'SHA1'
 	switch (hash.name) {
 	case 'SHA-256':
 		hashName = 'SHA256'
@@ -100,15 +100,19 @@ function getSigAlgorithm(
 	case 'SHA-512':
 		hashName = 'SHA512'
 		break
+	case 'SHA-1':
+		hashName = 'SHA1'
+		break
 	default:
 		throw new Error(`Unsupported hash algorithm: ${hash.name}`)
 	}
 
 	switch (name) {
 	case 'RSASSA-PKCS1-v1_5':
+	case 'RSA-PKCS1-SHA1':
 		return `RSA-PKCS1-${hashName}`
 	case 'ECDSA':
-		if(hashName === 'SHA512') {
+		if(hashName === 'SHA512' || hashName === 'SHA1') {
 			throw new Error(`Unsupported hash algorithm for ECDSA: ${hashName}`)
 		}