Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPANS] underlineOffset is incompatible with the box-sizing: border-box #115

Open
oleksandr-danylchenko opened this issue Jul 1, 2024 · 0 comments

Comments

@oleksandr-danylchenko
Copy link
Contributor

Issue

The offset between the highlight and the underline is achieved using the paddingBottom of the span:

if (style.underlineOffset)
span.style.paddingBottom = `${style.underlineOffset}px`;

However, that span also has the height priorly assigned:

Therefore, when the popular box-sizing: border-box style is used, the paddingBottom applied after height becomes ineffective!

box-sizing: content-box box-sizing: border-box
image image
oleksandr-danylchenko added a commit to oleksandr-danylchenko/text-annotator-js that referenced this issue Jul 1, 2024
…to staging

# Conflicts:
#	packages/extension-tei/test/index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant