We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPANS
underlineOffset
box-sizing: border-box
The offset between the highlight and the underline is achieved using the paddingBottom of the span:
paddingBottom
span
text-annotator-js/packages/text-annotator/src/highlight/span/spansRenderer.ts
Lines 89 to 90 in 36958ad
height
Line 72 in 36958ad
Therefore, when the popular box-sizing: border-box style is used, the paddingBottom applied after height becomes ineffective!
box-sizing: content-box
The text was updated successfully, but these errors were encountered:
Merge branch 'refs/heads/recogito#115-fix-spans-underlying-offset' in…
14ba5bf
…to staging # Conflicts: # packages/extension-tei/test/index.html
No branches or pull requests
Issue
The offset between the highlight and the underline is achieved using the
paddingBottom
of thespan
:text-annotator-js/packages/text-annotator/src/highlight/span/spansRenderer.ts
Lines 89 to 90 in 36958ad
However, that
span
also has theheight
priorly assigned:text-annotator-js/packages/text-annotator/src/highlight/span/spansRenderer.ts
Line 72 in 36958ad
Therefore, when the popular
box-sizing: border-box
style is used, thepaddingBottom
applied afterheight
becomes ineffective!box-sizing: content-box
box-sizing: border-box
The text was updated successfully, but these errors were encountered: