From e0495646e38c96f96457d6dbefef159acb1e8869 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Dav=C3=B3?= Date: Wed, 20 Mar 2024 14:18:34 +0100 Subject: [PATCH 1/2] Merged two concats into one MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: David Davó --- recommenders/models/rlrmc/RLRMCdataset.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/recommenders/models/rlrmc/RLRMCdataset.py b/recommenders/models/rlrmc/RLRMCdataset.py index 7670105b3..673b0fe7c 100644 --- a/recommenders/models/rlrmc/RLRMCdataset.py +++ b/recommenders/models/rlrmc/RLRMCdataset.py @@ -68,8 +68,7 @@ def _data_processing(self, train, validation=None, test=None, mean_center=True): """ # Data processing and reindexing code is adopted from https://github.com/Microsoft/Recommenders/blob/main/recommenders/models/ncf/dataset.py # If validation dataset is None - df = train if validation is None else pd.concat([train, validation]) - df = df if test is None else pd.concat([df, test]) + df = pd.concat(filter(lambda x: x is not None, [train, validation, test])) # Reindex user and item index if self.user_idx is None: From 83933448851395ddb6d2a3bb4d4dd4a9ae4d0170 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Dav=C3=B3?= Date: Wed, 20 Mar 2024 19:18:33 +0100 Subject: [PATCH 2/2] Further simplified merge MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: David Davó --- recommenders/models/rlrmc/RLRMCdataset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recommenders/models/rlrmc/RLRMCdataset.py b/recommenders/models/rlrmc/RLRMCdataset.py index 673b0fe7c..4627eebe1 100644 --- a/recommenders/models/rlrmc/RLRMCdataset.py +++ b/recommenders/models/rlrmc/RLRMCdataset.py @@ -68,7 +68,7 @@ def _data_processing(self, train, validation=None, test=None, mean_center=True): """ # Data processing and reindexing code is adopted from https://github.com/Microsoft/Recommenders/blob/main/recommenders/models/ncf/dataset.py # If validation dataset is None - df = pd.concat(filter(lambda x: x is not None, [train, validation, test])) + df = pd.concat([train, validation, test]) # Reindex user and item index if self.user_idx is None: