[cache] Make --dry-run work with disabled parallelization + add e2e test

Author: dorrogeray

.github/workflows/e2e_consecutive_changes.yaml

@@ -22,6 +22,7 @@ jobs:
             fail-fast: false
             matrix:
                 php_version: ['8.1']
+                rector_disable_parallel: ['true', 'false']
                 directory:
                     - 'e2e/consecutive-changes-with-cache'
 
@@ -47,16 +48,24 @@ jobs:
             -   run: php ../e2eTestChangingRunnerWithCache.php -o expected-output-1-dry-run.diff --dry-run
                 working-directory: ${{ matrix.directory }}
                 continue-on-error: true
+                env:
+                    RECTOR_DISABLE_PARALLEL: ${{ matrix.rector_disable_parallel }}
 
             # run e2e test with dry run once more, we expect non-zero exit code again
             -   run: php ../e2eTestChangingRunnerWithCache.php -o expected-output-2-dry-run.diff --dry-run
                 working-directory: ${{ matrix.directory }}
                 continue-on-error: true
+                env:
+                    RECTOR_DISABLE_PARALLEL: ${{ matrix.rector_disable_parallel }}
 
             # run e2e test
             -   run: php ../e2eTestChangingRunnerWithCache.php -o expected-output-3.diff
                 working-directory: ${{ matrix.directory }}
+                env:
+                    RECTOR_DISABLE_PARALLEL: ${{ matrix.rector_disable_parallel }}
 
             # this tests that a 2nd run with cache and consecutive changes works, see https://github.com/rectorphp/rector-src/pull/3614#issuecomment-1507742338
             -   run: php ../e2eTestChangingRunnerWithCache.php -o expected-output-4.diff
                 working-directory: ${{ matrix.directory }}
+                env:
+                    RECTOR_DISABLE_PARALLEL: ${{ matrix.rector_disable_parallel }}

e2e/consecutive-changes-with-cache/rector.php

@@ -10,6 +10,10 @@
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->cacheClass(FileCacheStorage::class);
 
+    if (getenv('RECTOR_DISABLE_PARALLEL') === 'true') {
+        $rectorConfig->disableParallel();
+    }
+
     $rectorConfig->paths([
         __DIR__ . '/src',
     ]);

phpstan.neon

@@ -57,6 +57,7 @@ parameters:
 
     ignoreErrors:
         - '#Cognitive complexity for "Rector\\Parallel\\WorkerRunner\:\:run\(\)" is 12, keep it under 11#'
+        - '#Cognitive complexity for "Rector\\Core\\Application\\ApplicationFileProcessor\:\:processFiles\(\)" is 13, keep it under 11#'
         - '#Cognitive complexity for "Rector\\Php80\\NodeResolver\\SwitchExprsResolver\:\:resolve\(\)" is (.*?), keep it under 11#'
 
         -

src/Application/ApplicationFileProcessor.php

@@ -133,7 +133,7 @@ public function processFiles(array $files, Configuration $configuration): array
 
             if ($systemErrorsAndFileDiffs[Bridge::SYSTEM_ERRORS] !== []) {
                 $this->changedFilesDetector->invalidateFile($file->getFilePath());
-            } elseif (! $configuration->isDryRun()) {
+            } else if (! $configuration->isDryRun() || $systemErrorsAndFileDiffs[Bridge::FILE_DIFFS] === []) {
                 $this->changedFilesDetector->cacheFileWithDependencies($file->getFilePath());
             }