How to deal with PHPStan\ShouldNotHappenException: Internal error?

[Wirone]

We're on Rector 0.11.56 and currently we can't upgrade to newer version because tests for our custom Rector rules fail in random way (I run and I get 2 errors, I run again and I get 9...). Output does not help:

5) Utils\Rector\Tests\Rule\Naming\HungarianNotationRector\HungarianNotationRectorTest::test with data set #4 (RectorPrefix20211013\Symplify\SmartFileSystem\SmartFileInfo Object (...))
PHPStan\ShouldNotHappenException: Internal error.

phar:///app/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/ScopeContext.php:36
phar:///app/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php:1900
/app/vendor/rector/rector/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php:235
/app/vendor/rector/rector/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php:131
phar:///app/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php:317
phar:///app/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php:259
phar:///app/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php:474
phar:///app/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php:227
/app/vendor/rector/rector/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php:155
/app/vendor/rector/rector/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php:143
/app/vendor/rector/rector/packages/NodeTypeResolver/NodeScopeAndMetadataDecorator.php:81
/app/vendor/rector/rector/src/Application/FileProcessor.php:49
/app/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php:80
/app/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php:144
/app/vendor/rector/rector/src/Application/FileProcessor/PhpFileProcessor.php:81
/app/vendor/rector/rector/src/Application/ApplicationFileProcessor.php:76
/app/vendor/rector/rector/src/Application/ApplicationFileProcessor.php:57
/app/vendor/rector/rector/packages/Testing/PHPUnit/AbstractRectorTestCase.php:149
/app/vendor/rector/rector/packages/Testing/PHPUnit/AbstractRectorTestCase.php:114
/app/vendor/rector/rector/packages/Testing/PHPUnit/AbstractRectorTestCase.php:105
/app/utils/rector/tests/Rule/Naming/HungarianNotationRector/HungarianNotationRectorTest.php:18

How can I debug it efficiently, so I will find actual problem? Because right now I don't know if it's our rule's problem or Rector's one.

[TomasVotruba]

Hi, it's hard to say where the issue is. Could you create reproductible repository?

[TomasVotruba]

Most likely this file change: https://github.com/rectorphp/rector-src/pull/952/files#diff-625e519d3d496a50287cab05a2ffb79a95877d1850083f9a90fdd74958a01020

[Wirone]

@TomasVotruba I think it's a good path, when I removed 2 fixtures for traits the other fixtures were tested properly on dev-main#84e32824ab48adc4b4489f3accc5f27dbc22d4a4 👍 I'll try to find what's the problem with those fixtures. Thank you!

In the meantime I'll leave here those fixtures, maybe you will find out what's the problem:

<?php

namespace Utils\Rector\Tests\Rule\Naming\HungarianNotationRector\Fixture;

trait Foo
{
    abstract public function bar($pBar, $mBaz);
}

?>
-----
<?php

namespace Utils\Rector\Tests\Rule\Naming\HungarianNotationRector\Fixture;

trait Foo
{
    abstract public function bar($bar, $baz);
}

?>

and

<?php

namespace Utils\Rector\Tests\Rule\Naming\HungarianNotationRector\Fixture;

// No changes should be made here by Rector - we can't properly determine trait usage and name conflicts for properties

trait Foo
{
    private $mFoo = 0;
    private $pBar = 1;
}

[TomasVotruba]

At first sight, the traits should have unique name. Now both files have the same name.

Sometimes it makes bugs, as the container in one test is build just once.

[Wirone]

@TomasVotruba Bingo! After renaming classes, interfaces and traits to unique names within namespace (fixtures for the same rule) it passes correctly! 😁 Thank you very much 🍻

PS. That weird tests results (2 errors, 9 errors, 2 errors and so on) probably were caused by executionOrder="defects" in PHPUnit's config. So every other run was in the opposite order which was causing different collisions of identifiers).

[TomasVotruba]

Great, I'm glad it works 👍 👏