Stop deferring record batch read

It's not safe because users may not consume result.

Author: kou

lib/activerecord_adbc_adapter/database_statements.rb

@@ -7,36 +7,26 @@ def perform_query(raw_connection,
                       prepare:,
                       notification_payload:,
                       batch:)
-      statement = raw_connection.open_statement
-      begin
+      raw_connection.open_statement do |statement|
         statement.sql_query = sql
         if binds.empty?
-          reader = statement.execute do |r,|
-            r
-          end
+          statement.execute[0]
         else
           statement.prepare
           raw_records = {}
           binds.zip(type_casted_binds) do |bind, type_casted_bind|
             raw_records[bind.name] = [type_casted_bind]
           end
           record_batch = Arrow::RecordBatch.new(raw_records)
-          reader = statement.bind(record_batch) do
-            statement.execute do |r,|
-              r
-            end
+          statement.bind(record_batch) do
+            statement.execute[0]
           end
         end
-      rescue
-        statement.release
-        raise
-      else
-        Result.new(statement, reader)
       end
     end
 
-    def cast_result(result)
-      result
+    def cast_result(table)
+      Result.new(table)
     end
 
     # Borrowed from

lib/activerecord_adbc_adapter/result.rb

@@ -2,10 +2,9 @@ module ActiveRecordADBCAdapter
   class Result
     include Enumerable
 
-    def initialize(statement, record_batch_reader)
-      @statement = statement
-      @record_batch_reader = record_batch_reader
-      @schema = @record_batch_reader.schema
+    def initialize(table)
+      @table = table
+      @schema = @table.schema
     end
 
     def columns
@@ -48,20 +47,17 @@ def indexed_rows
     end
 
     def to_arrow
-      @table ||= consume_record_batch_reader do
-        @record_batch_reader.read_all
-      end
+      @table
     end
 
     def each_record_batch
       return to_enum(__method__) unless block_given?
 
-      consume_record_batch_reader do
-        loop do
-          record_batch = @record_batch_reader.read_next
-          break if record_batch.nil?
-          yield(record_batch)
-        end
+      reader = Arrow::TableBatchReader.new(@table)
+      loop do
+        record_batch = reader.read_next
+        break if record_batch.nil?
+        yield(record_batch)
       end
     end
 
@@ -70,16 +66,6 @@ def fields
       @fields ||= @schema.fields
     end
 
-    def consume_record_batch_reader
-      begin
-        yield
-      ensure
-        @record_batch_reader = nil
-        @statement.release
-        @statement = nil
-      end
-    end
-
     def resolve_type(data_type)
       case data_type
       when Arrow::Int32DataType