duckdb: Add support for auto increment primary key

Author: kou

lib/active_record/connection_adapters/adbc/schema_creation.rb

@@ -0,0 +1,48 @@
+module ActiveRecord
+  module ConnectionAdapters
+    module ADBC
+      class SchemaCreation < ConnectionAdapters::SchemaCreation
+        private def quote_string(s)
+          @conn.quote_string(s)
+        end
+
+        private def sequence_name(column)
+          "sequence_#{column.table.name}_#{column.name}"
+        end
+
+        private def quoted_sequence_name(column)
+          quote_table_name(sequence_name(column))
+        end
+
+        def visit_ColumnDefinition(o)
+          sql = super
+          if o.type == :primary_key and @conn.backend == "duckdb"
+            sql << " DEFAULT NEXTVAL('#{quote_string(sequence_name(o))}')"
+          end
+          sql
+        end
+
+        def visit_TableDefinition(o)
+          o.columns.each do |column|
+            column.singleton_class.define_method(:table) do
+              o
+            end
+          end
+          sql = super
+          if @conn.backend == "duckdb"
+            o.columns.each do |column|
+              if column.type == :primary_key
+                s = +"CREATE SEQUENCE"
+                s << " IF NOT EXISTS" if o.if_not_exists
+                s << " #{quoted_sequence_name(column)}"
+                s << "; #{sql}"
+                sql = s
+              end
+            end
+          end
+          sql
+        end
+      end
+    end
+  end
+end

lib/active_record/connection_adapters/adbc/schema_statements.rb

@@ -155,6 +155,10 @@ def create_table_definition(name, **options)
           ADBC::TableDefinition.new(self, name, **options)
         end
 
+        def schema_creation
+          ADBC::SchemaCreation.new(self)
+        end
+
         def new_column_from_field(table_name, field, definitions)
           ADBC::Column.new(field["column_name"],
                            field["xdbc_column_def"],

lib/active_record/connection_adapters/adbc_adapter.rb

@@ -4,6 +4,7 @@
 require_relative "adbc/database_statements"
 require_relative "adbc/quoting"
 require_relative "adbc/result"
+require_relative "adbc/schema_creation"
 require_relative "adbc/schema_definitions"
 require_relative "adbc/schema_statements"
 
@@ -150,11 +151,11 @@ def build_insert_sql(insert)
         sql
       end
 
-      private
       def backend
         @connection_parameters[:driver].gsub(/\Aadbc_driver_/, "")
       end
 
+      private
       def detect_features
         detect_features_method = "detect_features_#{backend}"
         if respond_to?(detect_features_method, true)

test/test-type.rb

@@ -5,7 +5,7 @@ def test_integer
     ActiveRecord::Base.connection.create_table("users") do |table|
       table.column :integer, :integer
     end
-    User.create!(id: 1, integer: 1)
+    User.create!(integer: 1)
     assert_equal(User.new(id: 1, integer: 1),
                  User.first)
   end