From 7379870bd68a1f2f186b798e685fdc078b327301 Mon Sep 17 00:00:00 2001 From: Jan Stourac Date: Sun, 13 Oct 2024 15:34:57 +0200 Subject: [PATCH] [Fix] the test for the package versions on images In the second part of this test, we have a selected list of packages so that we expect these packages to be same version amongst all the tested images. We have to reduce this list as now there are more packages that are expected not to be in the same version as was in past. --- .../Page/ODH/JupyterHub/JupyterLabLauncher.robot | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot b/ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot index 1bd3b2355..91333d74a 100644 --- a/ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot +++ b/ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot @@ -453,7 +453,6 @@ Verify Installed Labextension Version Check Versions In JupyterLab [Arguments] ${libraries-to-check} ${return_status} = Set Variable PASS - @{packages} = Create List Python Boto3 Kafka-Python Matplotlib Scikit-learn Pandas Scipy Numpy FOR ${libString} IN @{libraries-to-check} # libString = LibName vX.Y -> libDetail= [libName, X.Y] @{libDetail} = Split String ${libString} ${SPACE}v @@ -531,12 +530,18 @@ Check Versions In JupyterLab ${return_status} = Set Variable FAIL END END + + # Now check that selected list of packages has same version among all the images. + @{packages} = Create List Python Boto3 Kafka-Python Scipy + Continue For Loop If "${libDetail}[0]" not in ${packages} IF "${libDetail}[0]" not in ${package_versions} ... Set To Dictionary ${package_versions} ${libDetail}[0]=${libDetail}[1] IF "${package_versions["${libDetail}[0]"]}" != "${libDetail}[1]" ${return_status} = Set Variable FAIL - Run Keyword And Continue On Failure FAIL "${package_versions["${libDetail}[0]"]} != ${libDetail}[1]" + Run Keyword And Continue On Failure Fail + ... Version of this library in this image doesn't align with versions in other images + ... "${package_versions["${libDetail}[0]"]} != ${libDetail}[1]" END END RETURN ${return_status}