From 79c11259495a133133fd0f629ae1daf2b5d27c55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jiri=20Dan=C4=9Bk?= Date: Sun, 3 Mar 2024 18:48:56 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Jan Stourac --- ods_ci/selftests/utils/scripts/test_util.py | 5 ++++- ods_ci/utils/scripts/util.py | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ods_ci/selftests/utils/scripts/test_util.py b/ods_ci/selftests/utils/scripts/test_util.py index cef66995a..a67d5ff06 100644 --- a/ods_ci/selftests/utils/scripts/test_util.py +++ b/ods_ci/selftests/utils/scripts/test_util.py @@ -73,7 +73,10 @@ def test_stderr(self): def test_string_cmd(self): assert util.execute_command("echo hello world", print_stdout=False) == "hello world\n" - def test_list_cmd(self): + def test_list_cmd_single_list_item(self): + assert util.execute_command(["echo hello world"], print_stdout=False) == "hello world\n" + + def test_list_cmd_multiple_list_items(self): # this is surprising, but it's what subprocess.Popen does assert util.execute_command(["echo", "hello", "world"], print_stdout=False) == "\n" diff --git a/ods_ci/utils/scripts/util.py b/ods_ci/utils/scripts/util.py index b234b2784..5f1d53ff6 100644 --- a/ods_ci/utils/scripts/util.py +++ b/ods_ci/utils/scripts/util.py @@ -76,7 +76,7 @@ def execute_command(cmd, print_stdout=True): sys.stdout.flush() return "".join(output) except Exception as e: - log.exception("Starting the subprocess failed", exc_info=e) + log.exception(f"Starting the subprocess '{cmd}' failed", exc_info=e) return None