FIX S091 #84
Closed
FIX S091 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedCraft
suggested changes
Aug 25, 2024
There was a problem hiding this comment.
Мне не очень нравится идея пихать определения массивов в правило dataTypeName, т.к. по хорошему там исходя из названия должны быть только названия типов данных, а не сами типы. Я бы это правило поднял в сам dataType как альтернативное подправило (как сделано с dataTypeName LP_ STRING_ (COMMA_ STRING_)* RP_)
|
Замечания увидел, исправлю |
|
Cannot invoke "org.antlr.v4.runtime.tree.ParseTree.accept(org.antlr.v4.runtime.tree.ParseTreeVisitor)" because "tree" is null |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37.
request: CREATE TABLE S091_01 (ARR_INT2 INTEGER[4,5], ARR_INT3 INTEGER[4,5,6], ARR_INT6 INTEGER[4,5,6,7])
err message: You have an error in your SQL syntax: CREATE TABLE S091_01 (ARR_INT2 INTEGER45 ARR_INT3 INTEGER456 ARR_INT6 INTEGER4567) null
New Err message: Types.ARRAY: SQL type for this field is not yet supported.new err message:
Cannot invoke "org.antlr.v4.runtime.tree.ParseTree.accept(org.antlr.v4.runtime.tree.ParseTreeVisitor)" because "tree" is null