Fixing reference failure to root CA var when unset

dperaza4dustbit · dperaza4dustbit · commit f5b67410a7fc · 2025-09-22T16:16:46.000-04:00
Signed-off-by: David Perza &lt;dperaza@redhat.com&gt;
diff --git a/rhtap/common.sh b/rhtap/common.sh
@@ -49,10 +49,12 @@ prepare-registry-user-pass() {
 }
 
 function addRootCert() {
-    if [ ! -z "$CUSTOM_ROOT_CA" ]; then
+    if [ -n "${CUSTOM_ROOT_CA:-}" ]; then
         echo "Using provided CA bundle"
         echo "$CUSTOM_ROOT_CA" > /etc/pki/ca-trust/source/anchors/ca-bundle.crt
         update-ca-trust
+    else
+        echo "Custom root CA variable is not set. Make sure CA trust is established"
     fi
 }
 

Original file line number	Diff line number	Diff line change
`@@ -49,10 +49,12 @@ prepare-registry-user-pass() {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`function addRootCert() {`
`52`		`- if [ ! -z "$CUSTOM_ROOT_CA" ]; then`
	`52`	`+ if [ -n "${CUSTOM_ROOT_CA:-}" ]; then`
`53`	`53`	`echo "Using provided CA bundle"`
`54`	`54`	`echo "$CUSTOM_ROOT_CA" > /etc/pki/ca-trust/source/anchors/ca-bundle.crt`
`55`	`55`	`update-ca-trust`
	`56`	`+ else`
	`57`	`+ echo "Custom root CA variable is not set. Make sure CA trust is established"`
`56`	`58`	`fi`
`57`	`59`	`}`
`58`	`60`