CUSTOM_ROOT_CA: unbound variable

[pjos]

First of all, thanks for this great TSSC example collection of scripts for non Tekton CI's. Great work!

The execution environment is GitLab 18.2 with Runners on OpenShift 4.18, where our CA trust has been taken care of so there is no need for us to define CUSTOM_ROOT_CA.

The effect of that is that the build step, that uses set -u

tssc-dev-multi-ci/rhtap/buildah-rhtap.sh

Line 2 in 07cb4a4

set -euo pipefail

fails with

/work/rhtap/common.sh: line 53: CUSTOM_ROOT_CA: unbound variable in

tssc-dev-multi-ci/rhtap/common.sh

Line 52 in 07cb4a4

if [ ! -z "$CUSTOM_ROOT_CA" ]; then

Not a big issue with a lot of work arounds, but as a port of a golden path for TSSC adopters this should be addressed.

[dperaza4dustbit]

Thanks for the issue @pjos taking a look, just to be precise it looks like you change the script since lines 53 in error and 52 in line with the var reference don't match. Can you verify and provide the diff as well?

[dperaza4dustbit]

I think this should work, please review and try if possible: #340

[lcarva]

Something I just noticed: rhtap/common.sh sources the $DIR/rhtap/env.sh file (where $DIR is pwd). That file is generated when we create a new component via developer hub. And, by default, a value for CUSTOM_ROOT_CA is always set. This explains why we haven't seen this error before. We should still make the suggested changes though.

[pjos]

I think this should work, please review and try if possible: #340

I have tested suggestion and it still fails for me :-(

Some basic bash testing:

bash -uc 'if [ -n "$CUSTOM_ROOT_CA:-" ]; then echo set; else echo unset;fi'
bash: line 1: CUSTOM_ROOT_CA: unbound variable

As suggested in https://stackoverflow.com/questions/3601515/ddg#13864829

The testing of an unset variable seems to be working much better in the context of bash -u:

$ bash -uc 'if [ -z "${CUSTOM_ROOT_CA+x}" ]; then echo unset; else echo set;fi'
unset
$ CUSTOM_ROOT_CA=something bash -uc 'if [ -z "${CUSTOM_ROOT_CA+x}" ]; then echo unset; else echo set;fi'
set

[pjos]

Something I just noticed: rhtap/common.sh sources the $DIR/rhtap/env.sh file (where $DIR is pwd). That file is generated when we create a new component via developer hub. And, by default, a value for CUSTOM_ROOT_CA is always set. This explains why we haven't seen this error before. We should still make the suggested changes though.

@lcarva The project was actually created by DeveloperHub (TSSC/RHTAP 1.6), but it is possible this is some kind of an edge case or missed configuration of the TSSC stack.

[pjos]

@dperaza4dustbit

Have tested both cases, set/unset `CUSTOM_ROOT_CA' and the following seems to be working as expected. Reasoning in comment #339 (comment)

function addRootCert() {
    if [ -n "${CUSTOM_ROOT_CA+x}" ]; then
        echo "Using provided CA bundle"
        echo "$CUSTOM_ROOT_CA" > /etc/pki/ca-trust/source/anchors/ca-bundle.crt
        update-ca-trust
    else
        echo "Custom root CA variable is not set. Make sure CA trust is established"
    fi
}