Skip to content

Commit 062c57c

Browse files
authored
Ensure binary is present for release-checker (#543)
Signed-off-by: Jose R. Gonzalez <[email protected]>
1 parent 053dc5c commit 062c57c

File tree

1 file changed

+19
-1
lines changed

1 file changed

+19
-1
lines changed

.github/workflows/pr-functional-tests.yaml

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,29 @@ jobs:
123123
- name: Checkout PR branch # untrusted content!
124124
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
125125
with:
126-
ref: ${{ github.event.pull_request.head.ref }}
126+
ref: ${{ github.event.pull_request.head.sha }}
127127
repository: ${{ github.event.pull_request.head.repo.full_name }}
128128
path: "chart-verifier"
129129
persist-credentials: false
130130

131+
# TODO: May be worth caching this binary, given there are several places
132+
# that build the binary in workflows. For now, just build this to allow
133+
# functional tests to work as expected.
134+
- name: Setup Go
135+
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
136+
with:
137+
go-version-file: ./chart-verifier/go.mod
138+
139+
- name: Ensure Modules
140+
working-directory: ./chart-verifier
141+
run: make tidy
142+
143+
- name: Build Binary
144+
working-directory: ./chart-verifier
145+
run: make bin
146+
147+
# TODO: This release-checker call requires chart-verifier on disk.
148+
# Consider refactoring the script to remove this requirement.
131149
- name: Check if only release file in PR
132150
working-directory: ./chart-verifier
133151
id: check_version_in_PR

0 commit comments

Comments
 (0)