Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added accounts always reversed #370

Open
haf-tech opened this issue Aug 31, 2022 · 5 comments
Open

Added accounts always reversed #370

haf-tech opened this issue Aug 31, 2022 · 5 comments

Comments

@haf-tech
Copy link

Describe the bug
Trying to add a user to the ConfigMap argocd-cm, but after saving the value/field data.accounts is reversed.
From the ArgoCD docu/RH article is this field not managed by the operator

To Reproduce

  1. Add e.g. accounts.image-updater: apikey in the cm argocd-cm in openshift-gitops
  2. Save
  3. Reload, accounts.image-updater... is gone

Expected behavior
accounts is still in cm

Additional context

OCP version 4.10.22_1528
Red Hat OpenShift GitOps, 1.6.0 provided by Red Hat Inc.

@jannfis
Copy link
Member

jannfis commented Aug 31, 2022

Hi, the Operator owns the argocd-cm. Please use the extraConfig field in the ArgoCD's spec, e.g.

spec:
  extraConfig:
    accounts.image-updater: ....

@haf-tech
Copy link
Author

haf-tech commented Sep 1, 2022

thanks @jannfis
then we have to fix/update the article
https://access.redhat.com/solutions/6637881

argocd-cm is controlled by the operator but data.accounts is not.

@turbolocust
Copy link

This is a feature of release 1.6 and 1.6 is not yet marked as the stable release yet (at least that is what I can see in OpenShift). The article predates version 1.6, in case anyone is wondering why the extraConfig is missing.

@herzogf
Copy link

herzogf commented Mar 21, 2023

Thanks for the hint regarding extraConfig!
Nonetheless the article https://access.redhat.com/solutions/6637881 is wrong or - better - misleading as it states "Red Hat OpenShift Container Platform 4.x" as environment, without any further restrictions. It should then say "for GitOps Operator <1.6".
This is important as this article is proposed when you want to open a RH support case with this topic- and it just does not work with newer Operator versions (1.7 on our side).

Thanks!

@liuxiaoyu-git
Copy link

Not fix yet for GitOps Operator 1.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants