Refactor tesing infra

Author: ekohl

.gitignore

@@ -2,3 +2,4 @@ pkg/*
 build/*
 doc/
 .yardoc
+Gemfile.lock

.travis.yml

@@ -0,0 +1,11 @@
+---
+matrix:
+  fast_finish: true
+  include:
+    - rvm: 2.0.0
+      env: PUPPET_VERSION=3.8
+    - rvm: 2.1.9
+      env: PUPPET_VERSION=4.10
+    - rvm: 2.4.1
+      env: PUPPET_VERSION=5.0
+sudo: false

Gemfile

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gem 'metadata-json-lint'
+gem 'puppetlabs_spec_helper'
+gem 'puppet', ENV.key?('PUPPET_VERSION') ? "~> #{ENV['PUPPET_VERSION']}" : '>= 3.8'

Rakefile

@@ -1,18 +1,3 @@
-require 'rubygems'
 require 'puppetlabs_spec_helper/rake_tasks'
-require 'puppet-lint/tasks/puppet-lint'
-PuppetLint.configuration.send('disable_80chars')
-PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"]
 
-desc "Validate manifests, templates, and ruby files"
-task :validate do
-  Dir['manifests/**/*.pp'].each do |manifest|
-    sh "puppet parser validate --noop #{manifest}"
-  end
-  Dir['spec/**/*.rb','lib/**/*.rb'].each do |ruby_file|
-    sh "ruby -c #{ruby_file}" unless ruby_file =~ /spec\/fixtures/
-  end
-  Dir['templates/**/*.erb'].each do |template|
-    sh "erb -P -x -T '-' #{template} | ruby -c"
-  end
-end
+task :default => [:release_checks]

tests/init.pp examples/init.pp

@@ -1,7 +1,10 @@
 require 'spec_helper'
-describe 'access_insights_client' do
 
+describe 'access_insights_client' do
   context 'with defaults for all parameters' do
-    it { should contain_class('access_insights_client') }
+    it { is_expected.to compile.with_all_deps }
+    it { is_expected.to contain_package('redhat-access-insights') }
+    it { is_expected.to contain_file('/etc/cron.daily/redhat-access-insights').with_ensure('link') }
+    it { is_expected.to contain_file('/etc/cron.weekly/redhat-access-insights').with_ensure('absent') }
   end
 end

spec/classes/init_spec.rb

@@ -1,17 +1,5 @@
-dir = File.expand_path(File.dirname(__FILE__))
-$LOAD_PATH.unshift File.join(dir, 'lib')
-
-require 'mocha'
-require 'puppet'
-require 'rspec'
-require 'spec/autorun'
-
-Spec::Runner.configure do |config|
-    config.mock_with :mocha
+RSpec.configure do |c|
+  c.mock_with :rspec
 end
 
-# We need this because the RAL uses 'should' as a method.  This
-# allows us the same behaviour but with a different method name.
-class Object
-    alias :must :should
-end
+require 'puppetlabs_spec_helper/module_spec_helper'