BUG: TagFields are not adding default separtor of ","

[dynamiclynk]

new Schema()
            .AddTagField(NewFieldName("key"))
            .AddTagField(NewFieldName("id"))
            .AddTagField(NewFieldName("source"))

[dynamiclynk]

BUG ?

if (!string.IsNullOrEmpty(Separator) && Separator != ",")
{
    args.Add("SEPARATOR");
    args.Add(Separator);
}

So:

If Separator is null or "" → nothing is added.

If Separator == "," → nothing is added (because that’s the Redis default).

Only if Separator is non-empty and not , → it appends SEPARATOR ....

That’s why I don’t see it — the library deliberately skips adding SEPARATOR ,.

I set separator to ";" and it functions correctly.

[mgravell]

Hi, and thanks for the report. In a way, it isn't wrong - the docs are explicit:

The default is ,

So, at least semantically, it is doing the right thing, and allowing the implicit default to take effect. Can I ask: what is the impact of this? Is this causing some code path to misbehave? Or is the impact simply that FT.INFO doesn't explicitly specify the separator?

[mgravell]

If there is an actual problem that this causes (still waiting on that context), one option would be to change the default value in the API to be "", so that we can distinguish between implicit and explicit usage. But: we'd need to understand the impact of the issue first.

[dynamiclynk]

Hey @mgravell I will try to retest this today. But I did change the separator to ; in the method params.

I will remove it and see if the issues still occurs which was no results were being returned but the tag had "." in the text which I eventually realized I needed to escaped.

That still returned no results with the "" separator when defaulting to "," param default, but ';" did work and I assume another other allowed values would work it also showed in FT.INFO as expected.