Skip to content

Commit 5172c03

Browse files
authored
РИ-7256: align icons better in modules popover, replace SVG icons with redis-ui icons
1 parent 9484d6d commit 5172c03

File tree

2 files changed

+30
-20
lines changed

2 files changed

+30
-20
lines changed

redisinsight/ui/src/components/database-list-modules/DatabaseListModules.tsx

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ import { IconButton } from 'uiSrc/components/base/forms/buttons'
1212
import { ColorText } from 'uiSrc/components/base/text'
1313
import { RiTooltip } from 'uiSrc/components'
1414
import { RiIcon } from 'uiSrc/components/base/icons'
15+
import { Row } from 'uiSrc/components/base/layout/flex'
16+
import { RedisDefaultModules } from 'uiSrc/slices/interfaces'
1517
import { AdditionalRedisModule } from 'apiSrc/modules/database/models/additional.redis.module'
1618

1719
import styles from './styles.module.scss'
@@ -46,7 +48,11 @@ const DatabaseListModules = React.memo((props: Props) => {
4648

4749
const newModules: IDatabaseModule[] = sortModules(
4850
modules?.map(({ name: propName, semanticVersion = '', version = '' }) => {
49-
const module: ModuleInfo = DEFAULT_MODULES_INFO[propName]
51+
const isValidModuleKey = Object.values(RedisDefaultModules).includes(propName as RedisDefaultModules)
52+
53+
const module: ModuleInfo | undefined = isValidModuleKey
54+
? DEFAULT_MODULES_INFO[propName as RedisDefaultModules]
55+
: undefined
5056
const moduleName = module?.text || propName
5157

5258
const { abbreviation = '', name = moduleName } = getModule(moduleName)
@@ -87,7 +93,12 @@ const DatabaseListModules = React.memo((props: Props) => {
8793
const hasContent = !!content
8894
const hasAbbreviation = !!abbreviation
8995
return (
90-
<div className={styles.tooltipItem} key={content || abbreviation}>
96+
<Row
97+
align="center"
98+
gap="m"
99+
className={styles.tooltipItem}
100+
key={content || abbreviation}
101+
>
91102
{hasIcon && <RiIcon type={icon} />}
92103
{!hasIcon && hasAbbreviation && (
93104
<ColorText
@@ -102,8 +113,7 @@ const DatabaseListModules = React.memo((props: Props) => {
102113
{content}
103114
</ColorText>
104115
)}
105-
<br />
106-
</div>
116+
</Row>
107117
)
108118
},
109119
)

redisinsight/ui/src/constants/modules.ts

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,34 +20,34 @@ const rediSearchIcons: {
2020
iconDark: AllIconsType
2121
iconLight: AllIconsType
2222
} = {
23-
iconDark: 'RedisSearchDarkIcon',
24-
iconLight: 'RedisSearchLightIcon',
23+
iconDark: 'QuerySearchIcon',
24+
iconLight: 'QuerySearchIcon',
2525
}
2626

2727
export const DEFAULT_MODULES_INFO: ModulesInfoType = {
2828
[RedisDefaultModules.AI]: {
29-
iconDark: 'RedisAIDarkIcon',
30-
iconLight: 'RedisAILightIcon',
29+
iconDark: 'RedisAiIcon',
30+
iconLight: 'RedisAiIcon',
3131
text: DATABASE_LIST_MODULES_TEXT[RedisDefaultModules.AI],
3232
},
3333
[RedisDefaultModules.Bloom]: {
34-
iconDark: 'RedisBloomDarkIcon',
35-
iconLight: 'RedisBloomLightIcon',
34+
iconDark: 'ProbabilisticIcon',
35+
iconLight: 'ProbabilisticIcon',
3636
text: DATABASE_LIST_MODULES_TEXT[RedisDefaultModules.Bloom],
3737
},
3838
[RedisDefaultModules.Gears]: {
39-
iconDark: 'RedisGearsDarkIcon',
40-
iconLight: 'RedisGearsLightIcon',
39+
iconDark: 'RedisGearsIcon',
40+
iconLight: 'RedisGearsIcon',
4141
text: DATABASE_LIST_MODULES_TEXT[RedisDefaultModules.Gears],
4242
},
4343
[RedisDefaultModules.Graph]: {
44-
iconDark: 'RedisGraphDarkIcon',
45-
iconLight: 'RedisGraphLightIcon',
44+
iconDark: 'RedisGraphIcon',
45+
iconLight: 'RedisGraphIcon',
4646
text: DATABASE_LIST_MODULES_TEXT[RedisDefaultModules.Graph],
4747
},
4848
[RedisDefaultModules.RedisGears]: {
49-
iconDark: 'RedisGearsDarkIcon',
50-
iconLight: 'RedisGearsLightIcon',
49+
iconDark: 'RedisGearsIcon',
50+
iconLight: 'RedisGearsIcon',
5151
text: DATABASE_LIST_MODULES_TEXT[RedisDefaultModules.RedisGears],
5252
},
5353
[RedisDefaultModules.RedisGears2]: {
@@ -56,8 +56,8 @@ export const DEFAULT_MODULES_INFO: ModulesInfoType = {
5656
text: DATABASE_LIST_MODULES_TEXT[RedisDefaultModules.RedisGears2],
5757
},
5858
[RedisDefaultModules.ReJSON]: {
59-
iconDark: 'RedisJSONDarkIcon',
60-
iconLight: 'RedisJSONLightIcon',
59+
iconDark: 'JsonIcon',
60+
iconLight: 'JsonIcon',
6161
text: DATABASE_LIST_MODULES_TEXT[RedisDefaultModules.ReJSON],
6262
},
6363
[RedisDefaultModules.Search]: {
@@ -77,8 +77,8 @@ export const DEFAULT_MODULES_INFO: ModulesInfoType = {
7777
text: DATABASE_LIST_MODULES_TEXT[RedisDefaultModules.FTL],
7878
},
7979
[RedisDefaultModules.TimeSeries]: {
80-
iconDark: 'RedisTimeSeriesDarkIcon',
81-
iconLight: 'RedisTimeSeriesLightIcon',
80+
iconDark: 'TimeSeriesIcon',
81+
iconLight: 'TimeSeriesIcon',
8282
text: DATABASE_LIST_MODULES_TEXT[RedisDefaultModules.TimeSeries],
8383
},
8484
}

0 commit comments

Comments
 (0)