From ea9770e6a9a9ab75951a206acbfcf1e100d876f6 Mon Sep 17 00:00:00 2001 From: "xiaofan.chen" Date: Wed, 17 Jan 2024 19:40:23 +0800 Subject: [PATCH] chore: refine modifier of inActivationChannel --- .../io/lettuce/core/protocol/DefaultEndpoint.java | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/main/java/io/lettuce/core/protocol/DefaultEndpoint.java b/src/main/java/io/lettuce/core/protocol/DefaultEndpoint.java index 025a946a43..3ef9fb5a2e 100644 --- a/src/main/java/io/lettuce/core/protocol/DefaultEndpoint.java +++ b/src/main/java/io/lettuce/core/protocol/DefaultEndpoint.java @@ -63,11 +63,11 @@ public class DefaultEndpoint implements RedisChannelWriter, Endpoint, PushHandle private static final AtomicLong ENDPOINT_COUNTER = new AtomicLong(); - private static final AtomicIntegerFieldUpdater QUEUE_SIZE = AtomicIntegerFieldUpdater - .newUpdater(DefaultEndpoint.class, "queueSize"); + private static final AtomicIntegerFieldUpdater QUEUE_SIZE = AtomicIntegerFieldUpdater.newUpdater( + DefaultEndpoint.class, "queueSize"); - private static final AtomicIntegerFieldUpdater STATUS = AtomicIntegerFieldUpdater - .newUpdater(DefaultEndpoint.class, "status"); + private static final AtomicIntegerFieldUpdater STATUS = AtomicIntegerFieldUpdater.newUpdater( + DefaultEndpoint.class, "status"); private static final int ST_OPEN = 0; @@ -75,8 +75,6 @@ public class DefaultEndpoint implements RedisChannelWriter, Endpoint, PushHandle protected volatile Channel channel; - protected Channel inActivationChannel; - private final Reliability reliability; private final ClientOptions clientOptions; @@ -107,6 +105,8 @@ public class DefaultEndpoint implements RedisChannelWriter, Endpoint, PushHandle private boolean inActivation = false; + private Channel inActivationChannel; // No need to be volatile, since it is always accessed from the same thread. + private ConnectionWatchdog connectionWatchdog; private ConnectionFacade connectionFacade; @@ -286,7 +286,6 @@ private RedisException validateWrite(int commands) { return new RedisException("Connection is closed"); } - final boolean connected = isConnected(this.channel); if (usesBoundedQueues()) {