From 5b5fea3c60341f0ba67ab4438df356fd1ca9ca40 Mon Sep 17 00:00:00 2001 From: Binbin Date: Tue, 19 Mar 2024 15:14:25 +0800 Subject: [PATCH 1/2] Add the new ERRORSTATS_DISABLED error code note about ERRORSTATS abused --- commands/info.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/commands/info.md b/commands/info.md index 117a5da63..df6f68bc7 100644 --- a/commands/info.md +++ b/commands/info.md @@ -463,4 +463,8 @@ It won't be included when `INFO` or `INFO ALL` are called, and it is returned on **A note about the word slave used in this man page**: Starting with Redis 5, if not for backward compatibility, the Redis project no longer uses the word slave. Unfortunately in this command the word slave is part of the protocol, so we'll be able to remove such occurrences only when this API will be naturally deprecated. -**Modules generated sections**: Starting with Redis 6, modules can inject their info into the `INFO` command, these are excluded by default even when the `all` argument is provided (it will include a list of loaded modules but not their generated info fields). To get these you must use either the `modules` argument or `everything`., +**Modules generated sections**: Starting with Redis 6, modules can inject their info into the `INFO` command, these are excluded by default even when the `all` argument is provided (it will include a list of loaded modules but not their generated info fields). To get these you must use either the `modules` argument or `everything`. + +**Errorstats generated sections**: Starting with Redis 8, errorstats will be disabled when error code abuse is detected on the server side. +The server will print the warning log and the current errors code list, clear the errors code, and then replace it with a single `ERRORSTATS_DISABLED` error code to indicate that it is disabled in `INFO`. +It can be re-enabled using via `CONFIG RESETSTAT`. From 5ff9d4670f699521e9c8028c12e1df113f510a25 Mon Sep 17 00:00:00 2001 From: Binbin Date: Tue, 19 Mar 2024 15:43:00 +0800 Subject: [PATCH 2/2] code review from oran --- commands/info.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/commands/info.md b/commands/info.md index df6f68bc7..7180de786 100644 --- a/commands/info.md +++ b/commands/info.md @@ -428,6 +428,9 @@ For each error type, the following line is added: * `errorstat_XXX`: `count=XXX` +If the server detects that this section got flooded with too many errors, it'll get disabled, show a single `ERRORSTATS_DISABLED` error, and print the errors to the server log. +This can be reset by `CONFIG RESETSTAT`. + The **sentinel** section is only available in Redis Sentinel instances. It consists of the following fields: * `sentinel_masters`: Number of Redis masters monitored by this Sentinel instance @@ -464,7 +467,3 @@ It won't be included when `INFO` or `INFO ALL` are called, and it is returned on **A note about the word slave used in this man page**: Starting with Redis 5, if not for backward compatibility, the Redis project no longer uses the word slave. Unfortunately in this command the word slave is part of the protocol, so we'll be able to remove such occurrences only when this API will be naturally deprecated. **Modules generated sections**: Starting with Redis 6, modules can inject their info into the `INFO` command, these are excluded by default even when the `all` argument is provided (it will include a list of loaded modules but not their generated info fields). To get these you must use either the `modules` argument or `everything`. - -**Errorstats generated sections**: Starting with Redis 8, errorstats will be disabled when error code abuse is detected on the server side. -The server will print the warning log and the current errors code list, clear the errors code, and then replace it with a single `ERRORSTATS_DISABLED` error code to indicate that it is disabled in `INFO`. -It can be re-enabled using via `CONFIG RESETSTAT`.