Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not closing async generators causes issues downstream #3273

Open
agnesnatasya opened this issue Jun 10, 2024 · 0 comments
Open

not closing async generators causes issues downstream #3273

agnesnatasya opened this issue Jun 10, 2024 · 0 comments

Comments

@agnesnatasya
Copy link

Version: What redis-py and what redis version is the issue happening on?
redis-py 4.5.0

Platform: What platform / version? (For example Python 3.5.1 on Windows 7 / Ubuntu 15.10 / Azure)
Python 3.10

Description: Description of your issue, stack traces from errors and code that reproduces the issue

Some of the async generators, especially the rotate_slaves in asyncio/sentinel.py are not closed immediately using aclosing,. This is fine most of the time but it causes a PytestUnraisableExceptionWarning in some pytest runs downstream.
This can be easily fixed by adding an aclosing context manager but this is only supported after python 3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant