Skip to content

Commit d0b1017

Browse files
Remove test-cov
1 parent f0ac7fb commit d0b1017

File tree

8 files changed

+30
-113
lines changed

8 files changed

+30
-113
lines changed

.github/workflows/run_tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ jobs:
7575
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
7676
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
7777
run: |
78-
poetry run test-cov
78+
poetry run test-verbose
7979
8080
- name: Run tests
8181
if: matrix.connection != 'plain' || matrix.redis-stack-version != 'latest'
8282
run: |
83-
SKIP_VECTORIZERS=True SKIP_RERANKERS=True poetry run test-cov
83+
SKIP_VECTORIZERS=True SKIP_RERANKERS=True poetry run test-verbose
8484
8585
- name: Run notebooks
8686
if: matrix.connection == 'plain' && matrix.redis-stack-version == 'latest'

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,17 +78,17 @@ To run Testcontainers-based tests you need a local Docker installation such as:
7878

7979
Tests w/ vectorizers:
8080
```bash
81-
poetry run test-cov
81+
poetry run test-verbose
8282
```
8383

8484
Tests w/out vectorizers:
8585
```bash
86-
SKIP_VECTORIZERS=true poetry run test-cov
86+
SKIP_VECTORIZERS=true poetry run test-verbose
8787
```
8888

8989
Tests w/out rerankers:
9090
```bash
91-
SKIP_RERANKERS=true poetry run test-cov
91+
SKIP_RERANKERS=true poetry run test-verbose
9292
```
9393

9494
### Documentation

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ check-types:
1919
lint: format check-types
2020

2121
test:
22-
SKIP_RERANKERS=true SKIP_VECTORIZERS=true poetry run test-cov
22+
SKIP_RERANKERS=true SKIP_VECTORIZERS=true poetry run test-verbose
2323

2424
test-all:
25-
poetry run test-cov
25+
poetry run test-verbose
2626

2727
check: lint test
2828

poetry.lock

Lines changed: 4 additions & 99 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ black = ">=20.8b1"
5151
isort = ">=5.6.4"
5252
pylint = "3.1.0"
5353
pytest = "8.1.1"
54-
pytest-cov = "5.0.0"
5554
pytest-asyncio = "0.23.6"
5655
mypy = "1.9.0"
5756
types-redis = "*"
@@ -82,7 +81,6 @@ check-lint = "scripts:check_lint"
8281
check-mypy = "scripts:check_mypy"
8382
test = "scripts:test"
8483
test-verbose = "scripts:test_verbose"
85-
test-cov = "scripts:test_cov"
8684
cov = "scripts:cov"
8785
test-notebooks = "scripts:test_notebooks"
8886
build-docs = "scripts:build_docs"

redisvl/schema/fields.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ def as_redis_field(self) -> RedisField:
235235

236236
class FlatVectorField(BaseField):
237237
"Vector field with a FLAT index (brute force nearest neighbors search)"
238+
238239
type: str = Field(default="vector", const=True)
239240
attrs: FlatVectorFieldAttributes
240241

tests/integration/test_llmcache.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import asyncio
22
import os
3+
import warnings
34
from collections import namedtuple
45
from time import sleep, time
5-
import warnings
66

77
import pytest
88
from pydantic.v1 import ValidationError
@@ -918,11 +918,19 @@ def test_invalid_vectorizer(redis_url):
918918
def test_passes_through_dtype_to_default_vectorizer(redis_url):
919919
# The default is float32, so we should see float64 if we pass it in.
920920
cache = SemanticCache(
921-
name="test_pass_through_dtype", dtype="float64", redis_url=redis_url, overwrite=True
921+
name="test_pass_through_dtype",
922+
dtype="float64",
923+
redis_url=redis_url,
924+
overwrite=True,
922925
)
923926
assert cache._vectorizer.dtype == "float64"
924927

925928

926929
def test_deprecated_dtype_argument(redis_url):
927930
with pytest.warns(DeprecationWarning):
928-
SemanticCache(name="test_deprecated_dtype", dtype="float32", redis_url=redis_url, overwrite=True)
931+
SemanticCache(
932+
name="test_deprecated_dtype",
933+
dtype="float32",
934+
redis_url=redis_url,
935+
overwrite=True,
936+
)

tests/integration/test_session_manager.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -613,11 +613,16 @@ def test_invalid_vectorizer(redis_url):
613613
def test_passes_through_dtype_to_default_vectorizer(redis_url):
614614
# The default is float32, so we should see float64 if we pass it in.
615615
cache = SemanticSessionManager(
616-
name="test_pass_through_dtype", dtype="float64", redis_url=redis_url, overwrite=True
616+
name="test_pass_through_dtype",
617+
dtype="float64",
618+
redis_url=redis_url,
619+
overwrite=True,
617620
)
618621
assert cache._vectorizer.dtype == "float64"
619622

620623

621624
def test_deprecated_dtype_argument(redis_url):
622625
with pytest.warns(DeprecationWarning):
623-
SemanticSessionManager(name="float64 session", dtype="float64", redis_url=redis_url, overwrite=True)
626+
SemanticSessionManager(
627+
name="float64 session", dtype="float64", redis_url=redis_url, overwrite=True
628+
)

0 commit comments

Comments
 (0)