From 141c43bfde093647ec347a36fe1c6ac8a0c3a5b1 Mon Sep 17 00:00:00 2001 From: Willem Kaufmann Date: Wed, 2 Oct 2024 14:03:13 -0400 Subject: [PATCH] `rpk`: add `TODO` on hardcoded `config` section These workarounds should be removed in a future version of `redpanda` (once `v24.2` is EOL), now that bug fixes are in place in the core. They are left here for now to ensure backwards compatibility between an upgraded version of `rpk` and an un-upgraded `redpanda` cluster. --- src/go/rpk/pkg/cli/topic/config.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/go/rpk/pkg/cli/topic/config.go b/src/go/rpk/pkg/cli/topic/config.go index 81d6ee5e44c63..68d4a9f67bde3 100644 --- a/src/go/rpk/pkg/cli/topic/config.go +++ b/src/go/rpk/pkg/cli/topic/config.go @@ -76,6 +76,8 @@ valid, but does not apply it. // at the same time, so we issue first the set request for write, // then the rest of the requests. // See https://github.com/redpanda-data/redpanda/issues/9191 + // TODO: Remove this once v24.2 is EOL. + // See https://github.com/redpanda-data/redpanda/pull/23545. _, isRRR := setKVs["redpanda.remote.read"] wv, isRRW := setKVs["redpanda.remote.write"] rrwErrors := make(map[string]int16)