-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: updates iceberg property description #23576
Conversation
src/v/config/configuration.cc
Outdated
"is set to false, disables the feature at the cluster level effectively " | ||
"turning it off for all topics.", | ||
"When set to true, this enables the feature that translates topic data " | ||
"to Iceberg tables. This enables it at the cluster level, and it " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enables it at the cluster level
This gives an impression that the cluster level default is set to true, should we reword it to say that this only enables the feature and the default for all topics is still false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bharathv. How is this:
Enables the feature that translates topic data to Iceberg tables. When set to true, this enables the feature at the cluster level and requires individual topics to explicitly opt in by setting the iceberg.enabled topic-level property to true. When set to false, this disables the feature at the cluster level, effectively turning it off for all topics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55496#0192457e-b42e-4ba1-8b7a-0bb089cb0e1c ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55496#0192457e-b434-4777-880e-539ab24f7453 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55543#019248b3-051e-46a4-b3f9-79dea70a3750 |
930eab9
to
96059c9
Compare
Updated the PR with the latest suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks Paulo!
new failures in https://buildkite.com/redpanda/redpanda/builds/55543#019248c0-de55-4e7b-8166-7b9ec251d28d:
|
Updates
iceberg_enable
cluster property with documentation suggestions.Introduced on #23443
Backports Required
Release Notes