rptest: request feature state from each node in await_feature #23579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztlpn
previously approved these changes
Oct 1, 2024
|
new failures in https://buildkite.com/redpanda/redpanda/builds/55519#019247a1-468b-4226-b925-d8702516727d: new failures in https://buildkite.com/redpanda/redpanda/builds/55519#019247a5-525e-4e66-a6db-badb4cc9ba73: |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55519#019247a1-468e-49fd-8582-9f6b36b7cfa5 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55519#019247a5-5260-4b77-8ff2-5b3727778c05 |
Fixes ControllerSnapshotPolicyTest.test_snapshotting_policy test. Before the test would spuriously fail because it would try to deactivate and then reactive the feature before waiting for deactivation to finish. The admin endpoint checks feature state without a linearizable barrier to short-circuit execution if feature is already active. This is why we need to wait for previous command to be applied first. To make sure the in-memory state is updated. Also, request feature state only from started nodes. We have tests (i.e. upgrade tests) which try to enable features before all nodes are started.
nvartolomei
force-pushed
the
nv/test_snapshotting_policy
branch
from
07106c2 to
f068b0b
Compare
ztlpn
approved these changes
Oct 1, 2024
|
Thanks! |
|
/backport v24.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ControllerSnapshotPolicyTest.test_snapshotting_policy test.
Before the test would spuriously fail because it would try to deactivate and then reactive the feature before waiting for deactivation to finish.
The admin endpoint checks feature state without a linearizable barrier to short-circuit execution if feature is already active. This is why we need to wait for previous command to be applied first. To make sure the in-memory state is updated.
Regression likely introduced in #22533
Backports Required
Release Notes