[v24.2.x] rptest: make target_min_capacity_wanted more deterministic #23606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
approved these changes
Oct 3, 2024
|
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56147#01927263-a247-44e2-9b12-e836726395ca: |
Retry command for Build#56147please wait until all jobs are finished before running the slash command |
|
/ci-repeat 1 |
nvartolomei
force-pushed
the
backport-pr-23484-v24.2.x-712
branch
from
e93cc35 to
f37db01
Compare
Slightly improve readability of the test. No functional changes. Numbers stay the same in all expressions we just dynamically get the `storage_reserve_min_segments` (default: 2) to future proof the test and to make it clearer to the reader where the numbers come from. The logic mirrors what is happening in disk_log_impl.cc. In particular, for log without cleanup policy we 2x it's current size and multiply storage_reserve_min_segments by default segment size and take the maximum. (cherry picked from commit d9a8239)
Introduce linger.ms parameter to try and make batching in the test more deterministic when test is run on systems with different performance/load. (cherry picked from commit 98b6add)
nvartolomei
force-pushed
the
backport-pr-23484-v24.2.x-712
branch
from
f37db01 to
611986c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23484